Summary: smf: Add capability to redo CCBs that fail [#1398]
Review request for Ticket(s): 1398
Peer Reviewer(s): NA
Pull request to: NA
Affected branch(es): develop
Development branch: ticket-1398
Base revision: c4a934ba77290efcdcc76700cd024fb3871a3ebf
Personal repository: git://git.code.sf.net/u/elunlen/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
NOTE: Will not be pushed "as is" not yet complete.
Only create operation is implemented
TODO Implement also modify and delete
revision 18b4a319534bf3a2242f7d351766c78312ded749
Author: Lennart Lund <[email protected]>
Date: Wed, 20 Dec 2017 15:23:35 +0100
smf: Add capability to redo CCBs that fail [#1398]
Create a module for handling IMM CCB that implements all steps involved and
all rules regaring possible recovery and failing
Replace current CCB handling in SMF with useage of this module
NOTE: This is an early version that is not well tested and everything is not
yet implemented. Also some refactoring can be done (redundency). In some
places LLDTEST tagged traces, logs and printouts exists that will be
removed
or modified in a final version
- Only SaUint32T, SaInt32T and SaStringT is implemented.
Means that IMM type SA_IMM_ATTR_SAUINT32T, SA_IMM_ATTR_SAINT32T and
SA_IMM_ATTR_SASTRINGT can be set as value type
- A program called ccbdemo1 is included that can be used as an example and
for some testing. This program is built and will be installed in an OpenSAF
uml cluster if --enable-tests is set in configure
- An IMM class definition, democlass.xml, for ccbdemo1 is provided. This class
must be installed before ccbdemo1 can be executed
Example: # immcfg -f /hostfs/democlass.xml
Added Files:
------------
src/smf/config/democlass.xml
src/smf/smfd/imm_modify_config/attribute.cc
src/smf/smfd/imm_modify_config/attribute.h
src/smf/smfd/imm_modify_config/creator.cc
src/smf/smfd/imm_modify_config/creator.h
src/smf/smfd/imm_modify_config/immccb.cc
src/smf/smfd/imm_modify_config/immccb.h
src/smf/smfd/imm_modify_config/README
src/smf/smfd/imm_modify_demo/ccbdemo1.cc
src/smf/smfd/imm_modify_demo/democlass.xml
src/smf/smfd/imm_modify_demo/Makefile
src/smf/smfd/imm_om_api/common/common.cc
src/smf/smfd/imm_om_api/common/common.h
src/smf/smfd/imm_om_api/common/imm_attribute.cc
src/smf/smfd/imm_om_api/common/imm_attribute.h
src/smf/smfd/imm_om_api/om_admin_owner_clear.cc
src/smf/smfd/imm_om_api/om_admin_owner_clear.h
src/smf/smfd/imm_om_api/om_admin_owner_handle.cc
src/smf/smfd/imm_om_api/om_admin_owner_handle.h
src/smf/smfd/imm_om_api/om_admin_owner_set.cc
src/smf/smfd/imm_om_api/om_admin_owner_set.h
src/smf/smfd/imm_om_api/om_ccb_handle.cc
src/smf/smfd/imm_om_api/om_ccb_handle.h
src/smf/smfd/imm_om_api/om_ccb_object_create.cc
src/smf/smfd/imm_om_api/om_ccb_object_create.h
src/smf/smfd/imm_om_api/om_ccb_object_delete.cc
src/smf/smfd/imm_om_api/om_ccb_object_delete.h
src/smf/smfd/imm_om_api/om_ccb_object_modify.cc
src/smf/smfd/imm_om_api/om_ccb_object_modify.h
src/smf/smfd/imm_om_api/om_handle.cc
src/smf/smfd/imm_om_api/om_handle.h
Complete diffstat:
------------------
src/smf/Makefile.am | 85 +++-
src/smf/config/democlass.xml | 76 +++
src/smf/smfd/SmfImmOperation.cc | 2 +-
src/smf/smfd/imm_modify_config/README | 126 +++++
src/smf/smfd/imm_modify_config/attribute.cc | 217 +++++++++
src/smf/smfd/imm_modify_config/attribute.h | 150 ++++++
src/smf/smfd/imm_modify_config/creator.cc | 109 +++++
src/smf/smfd/imm_modify_config/creator.h | 44 ++
src/smf/smfd/imm_modify_config/immccb.cc | 560 +++++++++++++++++++++++
src/smf/smfd/imm_modify_config/immccb.h | 377 +++++++++++++++
src/smf/smfd/imm_modify_demo/Makefile | 19 +
src/smf/smfd/imm_modify_demo/ccbdemo1.cc | 221 +++++++++
src/smf/smfd/imm_modify_demo/democlass.xml | 76 +++
src/smf/smfd/imm_om_api/common/common.cc | 56 +++
src/smf/smfd/imm_om_api/common/common.h | 155 +++++++
src/smf/smfd/imm_om_api/common/imm_attribute.cc | 112 +++++
src/smf/smfd/imm_om_api/common/imm_attribute.h | 212 +++++++++
src/smf/smfd/imm_om_api/om_admin_owner_clear.cc | 80 ++++
src/smf/smfd/imm_om_api/om_admin_owner_clear.h | 71 +++
src/smf/smfd/imm_om_api/om_admin_owner_handle.cc | 88 ++++
src/smf/smfd/imm_om_api/om_admin_owner_handle.h | 94 ++++
src/smf/smfd/imm_om_api/om_admin_owner_set.cc | 122 +++++
src/smf/smfd/imm_om_api/om_admin_owner_set.h | 91 ++++
src/smf/smfd/imm_om_api/om_ccb_handle.cc | 104 +++++
src/smf/smfd/imm_om_api/om_ccb_handle.h | 82 ++++
src/smf/smfd/imm_om_api/om_ccb_object_create.cc | 85 ++++
src/smf/smfd/imm_om_api/om_ccb_object_create.h | 170 +++++++
src/smf/smfd/imm_om_api/om_ccb_object_delete.cc | 60 +++
src/smf/smfd/imm_om_api/om_ccb_object_delete.h | 74 +++
src/smf/smfd/imm_om_api/om_ccb_object_modify.cc | 87 ++++
src/smf/smfd/imm_om_api/om_ccb_object_modify.h | 187 ++++++++
src/smf/smfd/imm_om_api/om_handle.cc | 151 ++++++
src/smf/smfd/imm_om_api/om_handle.h | 103 +++++
33 files changed, 4244 insertions(+), 2 deletions(-)
Testing Commands:
-----------------
*** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES ***
Testing, Expected Results:
--------------------------
*** PASTE COMMAND OUTPUTS / TEST RESULTS ***
Conditions of Submission:
-------------------------
*** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC ***
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
