Summary: dtm: configure trace file size and no of backups in transportd.conf [#2731] Review request for Ticket(s): 2731 Peer Reviewer(s):anders.widell Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2731 Base revision: d231ba43f36ed056c6b83a5739d7aa166ea73317 Personal repository: git://git.code.sf.net/u/syam-talluri/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging y Configuration files y Startup scripts n SAF services n OpenSAF services y Core libraries n Samples n Tests n Other n NOTE: Patch(es) contain lines longer than 80 characers Comments (indicate scope for each "y" above): --------------------------------------------- revision 5043b420c8ff5dd70d8d2cbb4a40dd3f3305b08b Author: syam-talluri <syam.tall...@oracle.com> Date: Wed, 27 Dec 2017 15:19:18 +0530 dtm: configure trace file size and no of backups in transportd.conf [#2731] To make the trace file size and number of backups configurable we are introducing the transportd.conf. This file was read in startup of transportd and logwriter will be configured with values. If we want to change these values dynamically the transportd.conf was read in SIGUSR2 handling and propagated to newly created streams and logwriter objects. Already created streams and log writer objects are not touched Added Files: ------------ src/dtm/transport/transportd.conf Complete diffstat: ------------------ opensaf.spec.in | 2 + src/dtm/Makefile.am | 3 + src/dtm/transport/log_server.cc | 95 ++++++++++++++++++++++++++++-- src/dtm/transport/log_server.h | 10 +++- src/dtm/transport/log_writer.cc | 6 +- src/dtm/transport/log_writer.h | 4 +- src/dtm/transport/main.cc | 4 ++ src/dtm/transport/osaf-transport.in | 1 + src/dtm/transport/tests/log_writer_test.cc | 2 +- src/dtm/transport/transportd.conf | 13 ++++ 10 files changed, 129 insertions(+), 11 deletions(-) Testing Commands: ----------------- *** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES *** Testing, Expected Results: -------------------------- Enable the traces and check whether config file size and number of backups are getting effected or not Conditions of Submission: ------------------------- Ack from Reviewer Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel