Hi all,

As Ravi pointed out, relying on node id may affect many other flows. I have sent V2 patch that does not depend on node id.

Please ignore this patch to change to LOG_ER to LOG_WA.

Happy New Year!

Thanks,

Minh


On 28/12/17 16:46, Ravi Sekhar Reddy Konda wrote:
Hi Minh,

I think its better to notify using LOG_NO, instead of just log warning and 
return.
Because its not only during Shutting Down,  this routine is being called in 
many flows

Thanks,
Ravi

-----Original Message-----
From: Minh Chau [mailto:minh.c...@dektech.com.au]
Sent: Thursday, December 28, 2017 7:32 AM
To: hans.nordeb...@ericsson.com; ravisekhar.ko...@oracle.com; 
gary....@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net; Minh Chau <minh.c...@dektech.com.au>
Subject: [PATCH 1/1] amfd: Change LOG_ER to LOG_WA if nodeid is not found in 
node shutting down [#2737]

---
  src/amf/amfd/imm.cc | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amf/amfd/imm.cc b/src/amf/amfd/imm.cc index aef988f..f36584b 
100644
--- a/src/amf/amfd/imm.cc
+++ b/src/amf/amfd/imm.cc
@@ -2194,7 +2194,7 @@ void avd_imm_reinit_bg(void) {
    }
    node = avd_node_find_nodeid(avd_cb->node_id_avd);
    if (node == nullptr) {
-    LOG_ER("%s: invalid node ID (%x)", __FUNCTION__,
+    LOG_WA("%s: invalid node ID (%x)", __FUNCTION__,
          avd_cb->node_id_avd);
      return;
    }
--
2.7.4



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to