Summary: plm: handle race condition for EE instantiation [#2514]
Review request for Ticket(s): 2514
Peer Reviewer(s): Ravi, Mathi
Pull request to:
Affected branch(es): develop
Development branch: ticket-2514
Base revision: 52de0283e7ae33d948f26f37981f1c141ca0f448
Personal repository: git://git.code.sf.net/u/trguitar/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
revision 14dfc8f3e86559585b072a9c18025cb562caaeff
Author: Alex Jones <alex.jo...@genband.com>
Date: Tue, 2 Jan 2018 10:45:31 -0500
plm: handle race condition for EE instantiation [#2514]
Child EE which is a controller can get shutdown because its parent EE (host)
has not connected to PLM, yet.
If the controller is a VM, and the host is a payload, there is a race
condition when instantiating the EEs. If the host doesn't connect to PLM
first, then when the controller EE (child of host EE) connects to PLM, it
see that the host isn't instantiated, and shuts itself down.
If the controller child EE instantiates before the host has connected to PLM,
set a 20 second timer. If the host doesn't instantiate within this time, then
all child EEs will be shut down.
Complete diffstat:
------------------
src/plm/common/plms_evt.h | 3 +-
src/plm/plmd/plms_plmc.c | 79 +++++++++++++++++++++++++++++++++++++++++++++++
src/plm/plmd/plms_utils.c | 11 ++++++-
3 files changed, 91 insertions(+), 2 deletions(-)
Testing Commands:
-----------------
1) Create some VMs and run plmc on all of them including the host
2) Make one of the VMs the controller
3) Boot them all up.
Testing, Expected Results:
--------------------------
1) If controller VM EE connects to plmd before host does, make sure the VM
doesn't shut itself off
Conditions of Submission:
-------------------------
Jan 8 or ack from developer
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
