This is a good change, long pending. The patches look okay. Iam thinking about in-service upgradeability of especially IMM(FEVS) and CKPT!
Cheers, Mathi. On Thu, Dec 21, 2017 at 11:25 AM, Anders Widell <[email protected]> wrote: > Summary: ckpt: Use Node ID instead of slot and subslot to identify a node > [#2742] > Review request for Ticket(s): 2742 > Peer Reviewer(s): Ravi, Alex > Pull request to: > Affected branch(es): develop > Development branch: ticket-2742 > Base revision: ec8a376bdeb75f0ba0d418ba7d9e8f16958b34c3 > Personal repository: git://git.code.sf.net/u/anders-w/review > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files y > Startup scripts n > SAF services y > OpenSAF services y > Core libraries y > Samples n > Tests n > Other n > > NOTE: Patch(es) contain lines longer than 80 characers > > Comments (indicate scope for each "y" above): > --------------------------------------------- > > We move towards a flat addressing scheme by using Node ID instead of the > legacy > slot-id and subslot-id to identify nodes in the cluster. > > revision 80a9c99e61bb5fd0ba9be11b8dbbd883e679ebf2 > Author: Anders Widell <[email protected]> > Date: Thu, 21 Dec 2017 11:15:30 +0100 > > fm: Remove code dealing with slot and subslot [#2742] > > > > revision 0ab57addc962c020627936ddee759ec1319bfcb7 > Author: Anders Widell <[email protected]> > Date: Thu, 21 Dec 2017 11:15:30 +0100 > > base: Remove code dealing with slot and subslot [#2742] > > > > revision 6bb8114d64b1d1c1f2568e947c78c4afaa1c15e7 > Author: Anders Widell <[email protected]> > Date: Thu, 21 Dec 2017 11:15:30 +0100 > > plm: Use Node ID instead of slot and subslot to identify a node [#2742] > > > > revision fd7ddf09b1f8f7f6a9c706a170e0f330d3457274 > Author: Anders Widell <[email protected]> > Date: Thu, 21 Dec 2017 11:15:30 +0100 > > msg: Use Node ID instead of slot and subslot to identify a node [#2742] > > > > revision d19633d8d62f53bb1b6e3b335688659710e8c701 > Author: Anders Widell <[email protected]> > Date: Thu, 21 Dec 2017 11:15:21 +0100 > > msg: Convert MSG agent to C++ [#2742] > > > > revision ec64728f54cdb26d8d3f39f3fb668ccc5512d43a > Author: Anders Widell <[email protected]> > Date: Thu, 21 Dec 2017 11:12:34 +0100 > > imm: Use Node ID instead of slot and subslot to identify a node [#2742] > > > > revision aaa9ac98f1ff9f12f1d3da00f29c6e2546e56cef > Author: Anders Widell <[email protected]> > Date: Thu, 21 Dec 2017 11:12:34 +0100 > > mds: Use Node ID instead of slot and subslot to identify a node [#2742] > > > > revision d258476c6b5295d09bb2705fe25900a32c751b85 > Author: Anders Widell <[email protected]> > Date: Thu, 21 Dec 2017 11:12:34 +0100 > > ckpt: Use Node ID instead of slot and subslot to identify a node [#2742] > > > > Complete diffstat: > ------------------ > src/base/ncs_main_papi.h | 8 - > src/base/ncsgl_defs.h | 7 - > src/ckpt/ckptd/cpd_cb.h | 14 +- > src/ckpt/ckptd/cpd_db.c | 22 +-- > src/ckpt/ckptd/cpd_evt.c | 66 ++++---- > src/ckpt/ckptd/cpd_mds.c | 6 +- > src/ckpt/ckptd/cpd_proc.c | 44 ++--- > src/ckpt/ckptd/cpd_proc.h | 3 +- > src/ckpt/ckptd/cpd_sbevt.c | 4 +- > src/ckpt/ckptnd/cpnd_cb.h | 13 +- > src/ckpt/ckptnd/cpnd_db.c | 19 +-- > src/ckpt/ckptnd/cpnd_init.h | 3 +- > src/ckpt/ckptnd/cpnd_mds.c | 32 ++-- > src/ckpt/ckptnd/cpnd_proc.c | 16 +- > src/fm/fmd/fm_mds.c | 2 +- > src/fm/fmd/fmd.conf | 6 - > src/imm/immd/immd_cb.h | 4 +- > src/imm/immd/immd_db.c | 21 +-- > src/imm/immd/immd_evt.c | 32 ++-- > src/imm/immd/immd_mds.c | 3 +- > src/imm/immd/immd_proc.c | 9 +- > src/imm/immd/immd_proc.h | 3 +- > src/imm/immnd/immnd_mds.c | 2 +- > src/mds/mds_c_db.c | 21 ++- > src/mds/mds_dt2c.h | 2 +- > src/mds/mds_dt_tcp.h | 2 +- > src/mds/mds_papi.h | 4 +- > src/msg/Makefile.am | 10 +- > src/msg/agent/{mqa_api.c => mqa_api.cc} | 241 > ++++++++++++++-------------- > src/msg/agent/{mqa_clbk.c => mqa_clbk.cc} | 38 +++-- > src/msg/agent/mqa_db.h | 4 +- > src/msg/agent/mqa_def.h | 13 +- > src/msg/agent/{mqa_init.c => mqa_init.cc} | 32 +++- > src/msg/agent/{mqa_mds.c => mqa_mds.cc} | 87 ++++++---- > src/msg/agent/mqa_mem.h | 14 +- > src/msg/agent/{mqa_queue.c => mqa_queue.cc} | 29 ++-- > src/msg/common/mqsv_asapi.c | 13 +- > src/msg/common/mqsv_asapi.h | 12 +- > src/msg/common/mqsv_common.c | 8 +- > src/msg/common/mqsv_common.h | 10 +- > src/msg/common/mqsv_edu.h | 8 + > src/msg/common/mqsv_mem.h | 6 +- > src/msg/msgd/mqd_mds.c | 7 +- > src/msg/msgnd/mqnd_mds.c | 14 +- > src/plm/common/plms.h | 4 +- > src/plm/plmd/plms_mds.c | 15 +- > 46 files changed, 442 insertions(+), 491 deletions(-) > > > Testing Commands: > ----------------- > > Run regression tests. > > Testing, Expected Results: > -------------------------- > > Regression tests shall pass. > > Conditions of Submission: > ------------------------- > > Ack from reviewers, or on 2018-01-08 if no comments have been received. > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 y y > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, > user.email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > > > ------------------------------------------------------------ > ------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Opensaf-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/opensaf-devel > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
