Summary: consensus: add split brain prevention support [#64] Review request for Ticket(s): 64 Peer Reviewer(s): Anders, Hans, Quyen Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-64 Base revision: 51e30cbf5f891f2479013bf9ce4289a27c47aa17 Personal repository: git://git.code.sf.net/u/userid-2226215/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services y Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- revision 8fa393fce29e64872c696c2b2fc75461996ef839 Author: Gary Lee <[email protected]> Date: Wed, 10 Jan 2018 15:54:31 +1100 consensus: add split brain prevention support [#64] Added Files: ------------ src/osaf/consensus/Makefile src/osaf/consensus/keyvalue.cc src/osaf/consensus/keyvalue.h src/osaf/consensus/plugins/etcd.plugin src/osaf/consensus/plugins/sample.plugin src/osaf/consensus/service.cc src/osaf/consensus/service.h Complete diffstat: ------------------ 00-README.conf | 43 ++++++ Makefile.am | 4 +- src/amf/amfd/osaf-amfd.in | 4 + src/amf/amfd/role.cc | 35 ++++- src/fm/Makefile.am | 1 + src/fm/fmd/fm_main.cc | 12 ++ src/fm/fmd/fm_rda.cc | 26 ++++ src/fm/fmd/fmd.conf | 8 ++ src/osaf/Makefile.am | 8 +- src/osaf/consensus/Makefile | 18 +++ src/osaf/consensus/keyvalue.cc | 165 ++++++++++++++++++++++ src/osaf/consensus/keyvalue.h | 57 ++++++++ src/osaf/consensus/plugins/etcd.plugin | 217 +++++++++++++++++++++++++++++ src/osaf/consensus/plugins/sample.plugin | 162 ++++++++++++++++++++++ src/osaf/consensus/service.cc | 231 +++++++++++++++++++++++++++++++ src/osaf/consensus/service.h | 66 +++++++++ src/rde/Makefile.am | 3 +- src/rde/rded/osaf-rded.in | 4 + src/rde/rded/rde_cb.h | 3 +- src/rde/rded/rde_main.cc | 32 ++++- src/rde/rded/role.cc | 45 +++++- src/rde/rded/role.h | 2 + 22 files changed, 1130 insertions(+), 16 deletions(-) Testing Commands: ----------------- *** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES *** Testing, Expected Results: -------------------------- *** PASTE COMMAND OUTPUTS / TEST RESULTS *** Conditions of Submission: ------------------------- *** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC *** Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
