I will update the README file before pushing.
Regarding CHASSIS_ID and SUBSLOT_ID: the values 2 and 15 are used as
default values only, in the case when /etc/opensaf/chassis_id and
/etc/opensaf/subslot_id are missing. If the files are present then the
values are configured in the files are used.
regards,
Anders Widell
On 01/19/2018 09:57 AM, Ravi Sekhar Reddy Konda wrote:
Hi Anders,
Ack, reviewed & tested (combinations also)
Update the README(if you are pushing #2759 immediately, you can do after #2759)
one minor comment, in generate_nodeid you hardcoded chassis_id & subslot_id
+ CHASSIS_ID=2
+ SUBSLOT_ID=15
I understand we are not taking them as config values, but better to define them in #defines
Thanks,
Ravi
-----Original Message-----
From: Anders Widell [mailto:[email protected]]
Sent: Friday, January 12, 2018 5:54 PM
To: Ravi Sekhar Reddy Konda <[email protected]>
Cc: [email protected]; Anders Widell
<[email protected]>
Subject: [PATCH 0/6] Review Request for dtm: Derive Node ID from IPv4 address
[#2758]
Summary: dtm: Derive Node ID from IPv4 address [#2758] Review request for
Ticket(s): 2758 Peer Reviewer(s): Ravi Pull request to:
Affected branch(es): develop
Development branch: ticket-2758
Base revision: 34a070372ff7cfe3caae7ec4e11a6681e19cdf31
Personal repository: git://git.code.sf.net/u/anders-w/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts y
SAF services y
OpenSAF services y
Core libraries y
Samples n
Tests y
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
revision c9161898793a57ce1db18be5343b9ea2a372271e
Author: Anders Widell <[email protected]>
Date: Fri, 12 Jan 2018 13:08:48 +0100
nid: Make chassis_id, slot_id and subslot_id in /etc/opensaf optional [#2758]
The files chassis_id, slot_id and subslot_id in /etc/opensaf no longer have to
be present. When they are missing, OpenSAF will derive the Node ID from the
TIPC address or the IPv4 address of the node.
revision 2500da3505f42aec23cc51eb0ec58091dadb14ea
Author: Anders Widell <[email protected]>
Date: Fri, 12 Jan 2018 13:08:48 +0100
msg: Allow any unsigned 32-bit value to be used as Node ID [#2758]
revision bc8ef895e4eb480416ab841d8c4ce1bf152fad82
Author: Anders Widell <[email protected]>
Date: Fri, 12 Jan 2018 13:08:48 +0100
lck: Allow any unsigned 32-bit value to be used as Node ID [#2758]
revision 629672485cba6356c73ca31d3eea5d475e1b4cf8
Author: Anders Widell <[email protected]>
Date: Fri, 12 Jan 2018 13:08:48 +0100
clm: Allow any unsigned 32-bit value to be used as Node ID [#2758]
Also fix the CLM API tests so that they longer assume that there is a node with
node ID 0x2010f in the cluster.
revision c10a688016d950ab16d09e08c63519de1c56e449
Author: Anders Widell <[email protected]>
Date: Fri, 12 Jan 2018 13:08:48 +0100
ckpt: Allow any unsigned 32-bit value to be used as Node ID [#2758]
revision 8b56c8eec0da20b95c46772b682b23413e666dfd
Author: Anders Widell <[email protected]>
Date: Fri, 12 Jan 2018 13:08:48 +0100
dtm: Derive Node ID from IPv4 address [#2758]
If the /var/lib/opensaf/node_id file doesn't exist when DTM starts, DTM will
create the file and use the IPv4 address as node ID. When using IPv6, the file
must still be configured manually. IPv6 support may be added in a future ticket.
Complete diffstat:
------------------
src/ckpt/apitest/test_cpsv.h | 2 +-
src/ckpt/ckptnd/cpnd_res.c | 18 ++---
src/ckpt/common/cpsv_evt.c | 2 +-
src/clm/apitest/clmtest.cc | 6 ++
src/clm/apitest/tet_saClmClusterNodeGet.cc | 23 +++---
src/clm/apitest/tet_saClmClusterNodeGetAsync.cc | 15 ++--
src/clm/apitest/tet_saClmClusterTrack.cc | 2 +-
src/clm/apitest/tet_saClmClusterTrackStop.cc | 4 +-
src/clm/apitest/tet_saClmDispatch.cc | 6 +-
src/clm/apitest/tet_saClmResponse.cc | 2 +-
src/dtm/dtmnd/dtm.h | 1 +
src/dtm/dtmnd/dtm_main.cc | 98 ++++++++++++++++---------
src/dtm/dtmnd/dtm_node_db.cc | 7 ++
src/dtm/dtmnd/dtm_read_config.cc | 6 --
src/lck/apitest/tet_gla.c | 4 +-
src/lck/apitest/tet_gld.c | 4 +-
src/lck/apitest/tet_glnd.c | 2 +-
src/lck/apitest/tet_glsv.h | 2 +-
src/msg/apitest/tet_mqa.c | 4 +-
src/msg/apitest/tet_mqsv.h | 2 +-
src/nid/opensafd.in | 49 ++++++-------
21 files changed, 149 insertions(+), 110 deletions(-)
Testing Commands:
-----------------
Start OpenSAF with IPv4 TCP transport, without configuring /etc/opensaf/slot_id
or /var/lib/opensaf/node_id
Testing, Expected Results:
--------------------------
OpenSAF shall use the IPv4 address as Node ID.
Conditions of Submission:
-------------------------
Ack from reviewer(s), or on 2018-01-19 if no comments have been received.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
