Summary: Add support for split brain prevention V3 [#64]
Review request for Ticket(s): 64
Peer Reviewer(s): Anders, Hans
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-64
Base revision: c5db5d0352af060cb94028b3b9b95e54d87cffbd
Personal repository: git://git.code.sf.net/u/userid-2226215/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs y
Build system y
RPM/packaging n
Configuration files y
Startup scripts n
SAF services y
OpenSAF services y
Core libraries y
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
Changes from V2:
osaf/consensus: remove opensaf_active_controller key
plugin: single persisent key used for lock
plugin: etcd plugin changed to put all opensaf related data under /opensaf
plugin: watch_lock function added to etcd plugin / sample plugin
rded: flag added to rded to ensure we don't launch multiple monitor threads
revision 39f15d483557e6b6623d9ccdab1bb5f02599d95d
Author: Gary Lee <gary....@dektech.com.au>
Date: Tue, 23 Jan 2018 18:58:50 +1100
doc: update README and makefiles [#64]
revision 9d31819b0c3e831372e58b56a311509b76c68634
Author: Gary Lee <gary....@dektech.com.au>
Date: Tue, 23 Jan 2018 18:58:37 +1100
fmd: update consensus service during controller failover [#64]
revision f03a578e94f964fbbcf5a217f95122e17d474dcd
Author: Gary Lee <gary....@dektech.com.au>
Date: Tue, 23 Jan 2018 18:58:08 +1100
amfd: update consensus service when performing SI swap [#64]
When a node goes down and split-brain prevention is enabled,
check that we still have write access to the consensus service.
If not and fencing is disabled, reboot the node to prevent
split brain.
revision c18b731daa26a5296468ad81cc30d1107e54c13f
Author: Gary Lee <gary....@dektech.com.au>
Date: Tue, 23 Jan 2018 18:57:46 +1100
rded: add split brain prevention support [#64]
* consult with consensus service before promoting node to active
* add watch thread and self-fence if it detects active controller
has been changed (if remote fencing is disabled)
revision a72528ea820ea0229b5034c45c22f8bb93b88986
Author: Gary Lee <gary....@dektech.com.au>
Date: Tue, 23 Jan 2018 18:57:27 +1100
osaf: add consensus API [#64]
Added Files:
------------
src/osaf/consensus/keyvalue.cc
src/osaf/consensus/keyvalue.h
src/osaf/consensus/Makefile
src/osaf/consensus/plugins/etcd.plugin
src/osaf/consensus/plugins/sample.plugin
src/osaf/consensus/service.cc
src/osaf/consensus/service.h
Complete diffstat:
------------------
00-README.conf | 56 +++++++
Makefile.am | 4 +-
src/amf/amfd/ndproc.cc | 12 +-
src/amf/amfd/osaf-amfd.in | 4 +
src/amf/amfd/role.cc | 30 +++-
src/fm/Makefile.am | 1 +
src/fm/fmd/fm_main.cc | 37 ++++-
src/fm/fmd/fm_rda.cc | 13 ++
src/fm/fmd/fmd.conf | 6 +
src/osaf/Makefile.am | 8 +-
src/osaf/consensus/Makefile | 18 +++
src/osaf/consensus/keyvalue.cc | 221 ++++++++++++++++++++++++++
src/osaf/consensus/keyvalue.h | 66 ++++++++
src/osaf/consensus/plugins/etcd.plugin | 253 ++++++++++++++++++++++++++++++
src/osaf/consensus/plugins/sample.plugin | 171 ++++++++++++++++++++
src/osaf/consensus/service.cc | 258 +++++++++++++++++++++++++++++++
src/osaf/consensus/service.h | 71 +++++++++
src/rde/Makefile.am | 3 +-
src/rde/rded/osaf-rded.in | 4 +
src/rde/rded/rde_cb.h | 4 +-
src/rde/rded/rde_main.cc | 38 ++++-
src/rde/rded/role.cc | 45 +++++-
src/rde/rded/role.h | 3 +
23 files changed, 1303 insertions(+), 23 deletions(-)
Testing Commands:
-----------------
*** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES ***
Testing, Expected Results:
--------------------------
*** PASTE COMMAND OUTPUTS / TEST RESULTS ***
Conditions of Submission:
-------------------------
*** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC ***
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
