Hi Ravi
The test cases are basically from Anders' design proposal. Eg.
- election clashes
- 2N si-swap
- isolating the network of the active controller, restore network before the
node is up
- isolating the network of the standby controller, restore network before the
node is up
- isolating the network of the active controller for longer durations
- isolating the network of the standby controller for longer durations
- above repeated with fencing enabled/disabled
- normal failover
The main constraint is we currently don't ensure the active controller comes
from the larger network partition.
If the key-value store is available during a split brain, there could be
improvements we could do in this regard.
We will address this in a future release.
Gary
On 25/1/18, 4:04 pm, "Ravi Sekhar Reddy Konda" <ravisekhar.ko...@oracle.com>
wrote:
Hi Gary,
I started reviewing this patch series
Can you please list the test cases that you have considered for testing
this( both with and without enabling Remote fencing)
Also please let us know if you see any design constraints with the
approach
Thanks,
Ravi
-----Original Message-----
From: Gary Lee [mailto:gary....@dektech.com.au]
Sent: Friday, January 19, 2018 5:09 PM
To: hans.nordeb...@ericsson.com; anders.wid...@ericsson.com;
quyen....@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 0/5] Review Request for Add support for split brain
prevention V2 [#64]
Summary: Add support for split brain prevention V2 [#64] Review request for
Ticket(s): 64 Peer Reviewer(s): Anders, Hans Pull request to: *** LIST THE
PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development
branch: ticket-64 Base revision: e1e0d2c0dc45a5ca7789f19d58dde0a41ed19354
Personal repository: git://git.code.sf.net/u/userid-2226215/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs y
Build system y
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
Changes from V1:
* fixed most cppcheck/cpplint errors in osaf/consensus
* disable self-fencing if remote-fencing is enabled
* reboot active controller if it loses quorum (write access)
* better error handling
revision 7ab1280243311058a6848c4da2b9738ab73dc861
Author: Gary Lee <gary....@dektech.com.au>
Date: Fri, 19 Jan 2018 22:29:42 +1100
doc: update README and makefiles [#64]
revision 625928304450399548c353473dea631a44aeecbe
Author: Gary Lee <gary....@dektech.com.au>
Date: Fri, 19 Jan 2018 22:28:59 +1100
fmd: update consensus service during controller failover [#64]
revision 42539da74893d5ce246242cf8d33c7875ea50fe8
Author: Gary Lee <gary....@dektech.com.au>
Date: Fri, 19 Jan 2018 22:26:19 +1100
amfd: update consensus service when performing SI swap [#64]
When a node goes down and split-brain prevention is enabled, check that we
still have write access to the consensus service.
If not and fencing is disabled, reboot the node to prevent split brain.
revision b6fcd4bede291ba5996b838c3fb784842648581e
Author: Gary Lee <gary....@dektech.com.au>
Date: Fri, 19 Jan 2018 22:23:14 +1100
rded: add split brain prevention support [#64]
* consult with consensus service before promoting node to active
* add watch thread and self-fence if it detects active controller
has been changed (if remote fencing is disabled)
revision 656b670a91a10e385604c98366239a28cde925f7
Author: Gary Lee <gary....@dektech.com.au>
Date: Fri, 19 Jan 2018 22:22:53 +1100
osaf: add consensus API [#64]
Added Files:
------------
src/osaf/consensus/Makefile
src/osaf/consensus/keyvalue.cc
src/osaf/consensus/keyvalue.h
src/osaf/consensus/plugins/etcd.plugin
src/osaf/consensus/plugins/sample.plugin
src/osaf/consensus/service.cc
src/osaf/consensus/service.h
Complete diffstat:
------------------
00-README.conf | 56 +++++++
Makefile.am | 4 +-
src/amf/amfd/ndproc.cc | 12 +-
src/amf/amfd/osaf-amfd.in | 4 +
src/amf/amfd/role.cc | 35 +++-
src/fm/Makefile.am | 1 +
src/fm/fmd/fm_main.cc | 37 ++++-
src/fm/fmd/fm_rda.cc | 28 ++++
src/fm/fmd/fmd.conf | 8 +
src/osaf/Makefile.am | 8 +-
src/osaf/consensus/Makefile | 18 ++
src/osaf/consensus/keyvalue.cc | 174 +++++++++++++++++++
src/osaf/consensus/keyvalue.h | 57 +++++++
src/osaf/consensus/plugins/etcd.plugin | 220 ++++++++++++++++++++++++
src/osaf/consensus/plugins/sample.plugin | 163 ++++++++++++++++++
src/osaf/consensus/service.cc | 277
+++++++++++++++++++++++++++++++
src/osaf/consensus/service.h | 75 +++++++++
src/rde/Makefile.am | 3 +-
src/rde/rded/osaf-rded.in | 4 +
src/rde/rded/rde_cb.h | 3 +-
src/rde/rded/rde_main.cc | 35 +++-
src/rde/rded/role.cc | 47 +++++-
src/rde/rded/role.h | 2 +
23 files changed, 1248 insertions(+), 23 deletions(-)
Testing Commands:
-----------------
*** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES ***
Testing, Expected Results:
--------------------------
*** PASTE COMMAND OUTPUTS / TEST RESULTS ***
Conditions of Submission:
-------------------------
*** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC ***
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email
etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most engaging
tech sites, Slashdot.org!
https://urldefense.proofpoint.com/v2/url?u=http-3A__sdm.link_slashdot&d=DwICAg&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=xBh_3WtlS1YjXd3Bui_nVjh5qwhU2UamdAhSfqynLU4&m=S3S8DOq84AL6s6qinyWCe-ahVno_gBaAFhyIs0o1Of4&s=OmpYXtbBUCFjVLkF0xrjbXVQejVoGHN7bnREqwjS1lQ&e=
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.sourceforge.net_lists_listinfo_opensaf-2Ddevel&d=DwICAg&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=xBh_3WtlS1YjXd3Bui_nVjh5qwhU2UamdAhSfqynLU4&m=S3S8DOq84AL6s6qinyWCe-ahVno_gBaAFhyIs0o1Of4&s=mbP7trG9EL0q90FBOQNkzcOUWeE2rm3lWUcm1Ig-HCA&e=
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
