Hi Anders Bjornerstedt, Do you mean we should move the validity check to IMMND (e.g: fevs local check) or have additional check at IMMND side?
I thought the check here is about validation of user's input parameters, then it could be better to detect invalid ones as early as possible. Regards, Vu > -----Original Message----- > From: and...@acm.org [mailto:anders.bjornerst...@telia.com] > Sent: Thursday, January 25, 2018 5:32 PM > To: vu.m.ngu...@dektech.com.au; ravisekhar.ko...@oracle.com; > zoran.milinko...@ericsson.com > Cc: opensaf-devel@lists.sourceforge.net > Subject: Re: [devel] [PATCH 0/1] Review Request for imm: not allow creating > reserved IMM class names [#2771] > > Hi, > > I think the general principle needs to be that validity checks to eliminate > the > risk of introducing database inconsistency needs to > be performed in the server. The server needs to protect itself from any faulty > client generating "fatal" messages. > > Thanks > Anders Bjornerstedt > > > > > >----Ursprungligt meddelande---- > >Från : vu.m.ngu...@dektech.com.au > >Datum : 2018-01-25 - 13:54 (GMT) > >Till : zoran.milinko...@ericsson.com, ravisekhar.ko...@oracle.com > >Kopia : opensaf-devel@lists.sourceforge.net > >Ämne : [devel] [PATCH 0/1] Review Request for imm: not allow creating > reserved IMM class names [#2771] > > > >Summary: imm: not allow creating reserved IMM class names [#2771] > >Review request for Ticket(s): 2771 > >Peer Reviewer(s): Zoran, Ravi > >Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** > >Affected branch(es): develop, release > >Development branch: ticket-2771 > >Base revision: c1daa9cc8e583d0a6024b28241f2b671bfa615d8 > >Personal repository: git://git.code.sf.net/u/winhvu/review > > > >-------------------------------- > >Impacted area Impact y/n > >-------------------------------- > > Docs n > > Build system n > > RPM/packaging n > > Configuration files n > > Startup scripts n > > SAF services y > > OpenSAF services n > > Core libraries n > > Samples n > > Tests n > > Other n > > > > > >Comments (indicate scope for each "y" above): > >--------------------------------------------- > >*** EXPLAIN/COMMENT THE PATCH SERIES HERE *** > > > >revision 8e072e9858c105266d7975ad366a579b720dfcae > >Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> > >Date: Thu, 25 Jan 2018 20:40:08 +0700 > > > >imm: not allow creating reserved IMM class names [#2771] > > > >PBE will be restarted and will never come up if user requests > >creating IMM class object class which is reserved by PBE. > > > >This patch adds code to reject such request with > SA_AIS_ERR_INVALID_PARAM. > > > > > > > >Complete diffstat: > >------------------ > > src/imm/agent/imma_om_api.cc | 27 ++++++++++++++++++++++++++- > > 1 file changed, 26 insertions(+), 1 deletion(-) > > > > > >Testing Commands: > >----------------- > >Create class, same name as reserved classes. E.g: "objects" > > > > > >Testing, Expected Results: > >-------------------------- > >Get SA_AIS_ERR_INVALID_PARAM and PBE is not restarted > > > > > >Conditions of Submission: > >------------------------- > >Get ack from peer reviewers > > > > > >Arch Built Started Linux distro > >------------------------------------------- > >mips n n > >mips64 n n > >x86 n n > >x86_64 n n > >powerpc n n > >powerpc64 n n > > > > > >Reviewer Checklist: > >------------------- > >[Submitters: make sure that your review doesn't trigger any checkmarks!] > > > > > >Your checkin has not passed review because (see checked entries): > > > >___ Your RR template is generally incomplete; it has too many blank entries > > that need proper data filled in. > > > >___ You have failed to nominate the proper persons for review and push. > > > >___ Your patches do not have proper short+long header > > > >___ You have grammar/spelling in your header that is unacceptable. > > > >___ You have exceeded a sensible line length in your > headers/comments/text. > > > >___ You have failed to put in a proper Trac Ticket # into your commits. > > > >___ You have incorrectly put/left internal data in your comments/files > > (i.e. internal bug tracking tool IDs, product names etc) > > > >___ You have not given any evidence of testing beyond basic build tests. > > Demonstrate some level of runtime or other sanity testing. > > > >___ You have ^M present in some of your files. These have to be removed. > > > >___ You have needlessly changed whitespace or added whitespace crimes > > like trailing spaces, or spaces before tabs. > > > >___ You have mixed real technical changes with whitespace and other > > cosmetic code cleanup changes. These have to be separate commits. > > > >___ You need to refactor your submission into logical chunks; there is > > too much content into a single commit. > > > >___ You have extraneous garbage in your review (merge commits etc) > > > >___ You have giant attachments which should never have been sent; > > Instead you should place your content in a public tree to be pulled. > > > >___ You have too many commits attached to an e-mail; resend as threaded > > commits, or place in a public tree for a pull. > > > >___ You have resent this content multiple times without a clear indication > > of what has changed between each re-send. > > > >___ You have failed to adequately and individually address all of the > > comments and change requests that were proposed in the initial review. > > > >___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email > etc) > > > >___ Your computer have a badly configured date and time; confusing the > > the threaded patch review. > > > >___ Your changes affect IPC mechanism, and you don't present any results > > for in-service upgradability test. > > > >___ Your changes affect user manual and documentation, your patch series > > do not contain the patch that updates the Doxygen manual. > > > > > >------------------------------------------------------------------------------ > >Check out the vibrant tech community on one of the world's most > >engaging tech sites, Slashdot.org! http://sdm.link/slashdot > >_______________________________________________ > >Opensaf-devel mailing list > >Opensaf-devel@lists.sourceforge.net > >https://lists.sourceforge.net/lists/listinfo/opensaf-devel > > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
