Summary: smf: Add capability to redo CCBs that fail [#1398]
Review request for Ticket(s): 1398
Peer Reviewer(s): Vijay Roy <vijay....@oracle.com>
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-1398
Base revision: 81ef74a531f84720fd905d25e3d06b1ff799f83d
Personal repository: git://git.code.sf.net/u/elunlen/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 2c77f3c292bf9f1d2b91114c1eccd58676efc58b
Author: Lennart Lund <lennart.l...@ericsson.com>
Date: Mon, 29 Jan 2018 13:24:48 +0100
smf: Add capability to redo CCBs that fail [#1398]
Second increment:
Class SmfAdminOperation is refactored to use the
CCB handler instead of handling IMM inline
The class is also moved from SmfUpgradeStep.* to
new files SmfAdminState.*
revision f5c32522323c37ae04eb325379bf86860c750fea
Author: Lennart Lund <lennart.l...@ericsson.com>
Date: Mon, 29 Jan 2018 13:20:33 +0100
smf: Add capability to redo CCBs that fail [#1398]
First increment:
A handler for modifying the IMM information model.
Implements the IMM Configuration Change part of the
IMM Object Manager. Handles all C API sequences
included in creating and applying a CCB including
possible recovery on temporary IMM failures.
Added Files:
------------
src/smf/config/democlass.xml
src/smf/smfd/imm_modify_config/add_operation_to_ccb.cc
src/smf/smfd/imm_modify_config/add_operation_to_ccb.h
src/smf/smfd/imm_modify_config/attribute.cc
src/smf/smfd/imm_modify_config/attribute.h
src/smf/smfd/imm_modify_config/immccb.cc
src/smf/smfd/imm_modify_config/immccb.h
src/smf/smfd/imm_modify_config/README
src/smf/smfd/imm_modify_demo/ccbdemo_create.cc
src/smf/smfd/imm_modify_demo/ccbdemo_delete.cc
src/smf/smfd/imm_modify_demo/ccbdemo_modify.cc
src/smf/smfd/imm_modify_demo/ccbhdl_test.cc
src/smf/smfd/imm_modify_demo/common.cc
src/smf/smfd/imm_modify_demo/common.h
src/smf/smfd/imm_modify_demo/democlass.xml
src/smf/smfd/imm_modify_demo/Makefile
src/smf/smfd/imm_modify_demo/README
src/smf/smfd/imm_om_ccapi/common/common.cc
src/smf/smfd/imm_om_ccapi/common/common.h
src/smf/smfd/imm_om_ccapi/common/imm_attribute.cc
src/smf/smfd/imm_om_ccapi/common/imm_attribute.h
src/smf/smfd/imm_om_ccapi/om_admin_owner_clear.cc
src/smf/smfd/imm_om_ccapi/om_admin_owner_clear.h
src/smf/smfd/imm_om_ccapi/om_admin_owner_handle.cc
src/smf/smfd/imm_om_ccapi/om_admin_owner_handle.h
src/smf/smfd/imm_om_ccapi/om_admin_owner_set.cc
src/smf/smfd/imm_om_ccapi/om_admin_owner_set.h
src/smf/smfd/imm_om_ccapi/om_ccb_handle.cc
src/smf/smfd/imm_om_ccapi/om_ccb_handle.h
src/smf/smfd/imm_om_ccapi/om_ccb_object_create.cc
src/smf/smfd/imm_om_ccapi/om_ccb_object_create.h
src/smf/smfd/imm_om_ccapi/om_ccb_object_delete.cc
src/smf/smfd/imm_om_ccapi/om_ccb_object_delete.h
src/smf/smfd/imm_om_ccapi/om_ccb_object_modify.cc
src/smf/smfd/imm_om_ccapi/om_ccb_object_modify.h
src/smf/smfd/imm_om_ccapi/om_handle.cc
src/smf/smfd/imm_om_ccapi/om_handle.h
src/smf/smfd/SmfAdminState.cc
src/smf/smfd/SmfAdminState.h
Complete diffstat:
------------------
opensaf.spec.in | 10 +
src/smf/Makefile.am | 201 ++-
src/smf/config/democlass.xml | 76 ++
src/smf/smfd/SmfAdminState.cc | 1298 ++++++++++++++++++++
src/smf/smfd/SmfAdminState.h | 141 +++
src/smf/smfd/SmfImmOperation.cc | 2 +-
src/smf/smfd/SmfUpgradeStep.cc | 1162 +-----------------
src/smf/smfd/SmfUpgradeStep.h | 94 --
src/smf/smfd/imm_modify_config/README | 129 ++
.../smfd/imm_modify_config/add_operation_to_ccb.cc | 258 ++++
.../smfd/imm_modify_config/add_operation_to_ccb.h | 73 ++
src/smf/smfd/imm_modify_config/attribute.cc | 630 ++++++++++
src/smf/smfd/imm_modify_config/attribute.h | 275 +++++
src/smf/smfd/imm_modify_config/immccb.cc | 657 ++++++++++
src/smf/smfd/imm_modify_config/immccb.h | 415 +++++++
src/smf/smfd/imm_modify_demo/Makefile | 19 +
src/smf/smfd/imm_modify_demo/README | 68 +
src/smf/smfd/imm_modify_demo/ccbdemo_create.cc | 445 +++++++
src/smf/smfd/imm_modify_demo/ccbdemo_delete.cc | 179 +++
src/smf/smfd/imm_modify_demo/ccbdemo_modify.cc | 281 +++++
src/smf/smfd/imm_modify_demo/ccbhdl_test.cc | 386 ++++++
src/smf/smfd/imm_modify_demo/common.cc | 66 +
src/smf/smfd/imm_modify_demo/common.h | 37 +
src/smf/smfd/imm_modify_demo/democlass.xml | 100 ++
src/smf/smfd/imm_om_ccapi/common/common.cc | 56 +
src/smf/smfd/imm_om_ccapi/common/common.h | 196 +++
src/smf/smfd/imm_om_ccapi/common/imm_attribute.cc | 115 ++
src/smf/smfd/imm_om_ccapi/common/imm_attribute.h | 238 ++++
src/smf/smfd/imm_om_ccapi/om_admin_owner_clear.cc | 80 ++
src/smf/smfd/imm_om_ccapi/om_admin_owner_clear.h | 82 ++
src/smf/smfd/imm_om_ccapi/om_admin_owner_handle.cc | 88 ++
src/smf/smfd/imm_om_ccapi/om_admin_owner_handle.h | 102 ++
src/smf/smfd/imm_om_ccapi/om_admin_owner_set.cc | 122 ++
src/smf/smfd/imm_om_ccapi/om_admin_owner_set.h | 97 ++
src/smf/smfd/imm_om_ccapi/om_ccb_handle.cc | 105 ++
src/smf/smfd/imm_om_ccapi/om_ccb_handle.h | 89 ++
src/smf/smfd/imm_om_ccapi/om_ccb_object_create.cc | 85 ++
src/smf/smfd/imm_om_ccapi/om_ccb_object_create.h | 172 +++
src/smf/smfd/imm_om_ccapi/om_ccb_object_delete.cc | 60 +
src/smf/smfd/imm_om_ccapi/om_ccb_object_delete.h | 79 ++
src/smf/smfd/imm_om_ccapi/om_ccb_object_modify.cc | 87 ++
src/smf/smfd/imm_om_ccapi/om_ccb_object_modify.h | 192 +++
src/smf/smfd/imm_om_ccapi/om_handle.cc | 155 +++
src/smf/smfd/imm_om_ccapi/om_handle.h | 104 ++
44 files changed, 8078 insertions(+), 1228 deletions(-)
Testing Commands:
-----------------
*** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES ***
Testing, Expected Results:
--------------------------
*** PASTE COMMAND OUTPUTS / TEST RESULTS ***
Conditions of Submission:
-------------------------
*** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC ***
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
