Summary: clm: Convert CLM to C++ [#2721] Review request for Ticket(s): 2721 Peer Reviewer(s): Ravi Pull request to: Affected branch(es): develop Development branch: ticket-2721 Base revision: 81ef74a531f84720fd905d25e3d06b1ff799f83d Personal repository: git://git.code.sf.net/u/anders-w/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n NOTE: Patch(es) contain lines longer than 80 characers Comments (indicate scope for each "y" above): --------------------------------------------- revision 17c6732f090ce721b596c5e1723392373c3f8954 Author: Anders Widell <[email protected]> Date: Tue, 30 Jan 2018 14:26:22 +0100 clm: Convert CLM to C++ [#2721] To support future implementation of tickets [#2618], [#2693] and [#2694], fully convert CLM to C++. This will also make it possible to remove the C++ wrappers in the CLM node agent, which will simplify the code. Complete diffstat: ------------------ src/clm/Makefile.am | 40 +- src/clm/agent/clma.h | 22 +- src/clm/agent/{clma_api.c => clma_api.cc} | 190 ++++---- src/clm/agent/{clma_mds.c => clma_mds.cc} | 131 +++--- src/clm/agent/{clma_util.c => clma_util.cc} | 81 ++-- src/clm/apitest/clmtest.cc | 8 +- src/clm/apitest/tet_ClmLongRdn.cc | 70 +-- src/clm/apitest/tet_ClmOiOps.cc | 26 +- src/clm/apitest/tet_saClmClusterNodeGet.cc | 28 +- src/clm/apitest/tet_saClmClusterNodeGetAsync.cc | 28 +- .../apitest/tet_saClmClusterNotificationFree.cc | 19 +- src/clm/apitest/tet_saClmClusterTrack.cc | 133 +++--- src/clm/apitest/tet_saClmClusterTrackStop.cc | 16 +- src/clm/apitest/tet_saClmDispatch.cc | 12 +- src/clm/apitest/tet_saClmFinalize.cc | 11 +- src/clm/apitest/tet_saClmInitialize.cc | 46 +- src/clm/apitest/tet_saClmResponse.cc | 36 +- src/clm/apitest/tet_saClmSelectionObjectGet.cc | 14 +- src/clm/clmd/clms.h | 72 ++-- src/clm/clmd/{clms_amf.c => clms_amf.cc} | 16 +- src/clm/clmd/clms_cb.h | 15 +- src/clm/clmd/{clms_evt.c => clms_evt.cc} | 229 +++++----- src/clm/clmd/clms_evt.h | 2 + src/clm/clmd/{clms_imm.c => clms_imm.cc} | 478 +++++++++++---------- src/clm/clmd/clms_imm.h | 15 +- src/clm/clmd/{clms_main.c => clms_main.cc} | 63 +-- src/clm/clmd/{clms_mbcsv.c => clms_mbcsv.cc} | 349 +++++++-------- src/clm/clmd/clms_mbcsv.h | 6 +- src/clm/clmd/{clms_mds.c => clms_mds.cc} | 105 ++--- src/clm/clmd/{clms_ntf.c => clms_ntf.cc} | 59 ++- src/clm/clmd/{clms_plm.c => clms_plm.cc} | 42 +- src/clm/clmd/{clms_util.c => clms_util.cc} | 158 +++---- src/clm/clmnd/{amf.c => amf.cc} | 8 +- src/clm/clmnd/cb.h | 7 +- src/clm/clmnd/election_starter.cc | 14 +- src/clm/clmnd/evt.h | 2 - src/clm/clmnd/{main.c => main.cc} | 106 ++--- .../common/{clmsv_enc_dec.c => clmsv_enc_dec.cc} | 17 +- src/clm/tools/{clm_print.c => clm_print.cc} | 81 ++-- 39 files changed, 1420 insertions(+), 1335 deletions(-) Testing Commands: ----------------- Run regression tests. Testing, Expected Results: -------------------------- Regression tests shall pass. Conditions of Submission: ------------------------- Ack from reviewer(s), or on 2018-02-06 if no comments have been received. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
