Hi Alex,

 

Ack from me, code review only.

 

Thank you

Srinivas

 

From: Alex Jones [mailto:ajo...@rbbn.com] 
Sent: Wednesday, January 31, 2018 8:02 PM
To: Srinivas Mangipudy <srinivas.mangip...@oracle.com>
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0/1] Review Request for msg: implement metadata size and 
limit fetch operations [#2626]

 

Hi Srinivas,

    If you have no comments, I will push this tomorrow.

Alex

 

On 01/26/2018 02:53 PM, Alex Jones wrote:

Summary: msg: implement metadata size and limit fetch operations [#2626]
Review request for Ticket(s): 2626
Peer Reviewer(s): Srinivas
Pull request to:
Affected branch(es): develop
Development branch: ticket-2626
Base revision: c1daa9cc8e583d0a6024b28241f2b671bfa615d8
Personal repository: git://git.code.sf.net/u/trguitar/review
 
--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            y
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   n
 
NOTE: Patch(es) contain lines longer than 80 characers
 
Comments (indicate scope for each "y" above):
---------------------------------------------
 
revision 6645a53f6323d39afb5e4de64b7429b6e7893d63
Author:  Alex Jones HYPERLINK "mailto:ajo...@rbbn.com";<ajo...@rbbn.com>
Date:    Fri, 26 Jan 2018 14:30:13 -0500
 
msg: implement metadata size and limit fetch operations [#2626]
 
This checkin implements metadata size and limit fetch operations, and
enforces them in other saMsg calls.
 
 
 
Added Files:
------------
 src/msg/apitest/test_LimitGet.cc
 src/msg/apitest/test_MetaDataSize.cc
 
 
Complete diffstat:
------------------
 src/msg/Makefile.am                    |   2 +
 src/msg/agent/mqa_api.cc               | 319 ++++++++++-
 src/msg/apitest/test_ErrUnavailable.cc |  68 ++-
 src/msg/apitest/test_LimitGet.cc       | 941 +++++++++++++++++++++++++++++++++
 src/msg/apitest/test_MetaDataSize.cc   |  94 ++++
 src/msg/common/mqsv_def.h              |   3 +
 src/msg/common/mqsv_edu.c              |  33 +-
 src/msg/common/mqsv_evt.h              |  25 +-
 src/msg/msgd/mqd_asapi.c               |  18 +
 src/msg/msgd/mqd_db.h                  |   1 +
 src/msg/msgd/mqd_imm.c                 |  10 +-
 src/msg/msgnd/mqnd_evt.c               | 153 ++++++
 src/msg/msgnd/mqnd_proc.c              |  28 +
 13 files changed, 1667 insertions(+), 28 deletions(-)
 
 
Testing Commands:
-----------------
run msgtest on payload
 
 
Testing, Expected Results:
--------------------------
all tests should pass
 
 
Conditions of Submission:
-------------------------
Feb 1 or ack from developer
 
 
Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      y          y
powerpc     n          n
powerpc64   n          n
 
 
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
 
 
Your checkin has not passed review because (see checked entries):
 
___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.
 
___ You have failed to nominate the proper persons for review and push.
 
___ Your patches do not have proper short+long header
 
___ You have grammar/spelling in your header that is unacceptable.
 
___ You have exceeded a sensible line length in your headers/comments/text.
 
___ You have failed to put in a proper Trac Ticket # into your commits.
 
___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)
 
___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.
 
___ You have ^M present in some of your files. These have to be removed.
 
___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.
 
___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.
 
___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.
 
___ You have extraneous garbage in your review (merge commits etc)
 
___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.
 
___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.
 
___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.
 
___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.
 
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
 
___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.
 
___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.
 
___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.
 

 
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to