Hi Minh,

Ack from my end.

Thank you

-----Original Message-----
From: Minh Chau [mailto:minh.c...@dektech.com.au] 
Sent: Monday, February 12, 2018 8:38 AM
To: canh.v.tru...@dektech.com.au
Cc: Minh Chau <minh.c...@dektech.com.au>; opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 0/1] Review Request for ntfd: Correct counting by in 
decode_reader_info [#2781]

Summary: ntfd: Correct counting by in decode_reader_info [#2781] Review request 
for Ticket(s): 2781 Peer Reviewer(s): Canh Pull request to: *** LIST THE PERSON 
WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: 
ticket-2781 Base revision: 05555005efbd2284a62847fe0aea4d1c8a2571bc
Personal repository: git://git.code.sf.net/u/minh-chau/review

Impacted area       Impact y/n
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            y
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   n

Comments (indicate scope for each "y" above):

revision d09532c11ad56910c6de5c2503fe790806bd299b
Author: Minh Chau <minh.c...@dektech.com.au>
Date:   Mon, 12 Feb 2018 14:00:55 +1100

ntfd: Correct counting by in decode_reader_info [#2781]

Complete diffstat:
 src/ntf/ntfd/ntfs_mbcsv.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Testing Commands:

Testing, Expected Results:

Conditions of Submission:
ack from reviewer

Arch      Built     Started    Linux distro
mips        n          n
mips64      n          n
x86         n          n
x86_64      y          y
powerpc     n          n
powerpc64   n          n

Reviewer Checklist:
[Submitters: make sure that your review doesn't trigger any checkmarks!]

Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.

Check out the vibrant tech community on one of the world's most engaging tech 
sites, Slashdot.org! 
Opensaf-devel mailing list

Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
Opensaf-devel mailing list

Reply via email to