Hi!
General comment: please make sure that the new code follows our Coding
Rules (see https://sourceforge.net/p/opensaf/wiki/Coding%20Rules/ ). In
particular, C++ code shall be formatted according to the Google C++
Style guide. As an aid to achieve this you can use the "make cpplint"
make target at the top of the OpenSAF source code tree to check the C++
code, and "make checkpatch" to check the C code. However, be aware that
we have not yet fixed all the style problems in our legacy code so you
will see a lot of warnings when you run this. But at least when writing
new code, please try to follow the style guide.
NOTE: Cpplint doesn't seem to complain about naming conventions, so pay
special attention to the Chapter
https://google.github.io/styleguide/cppguide.html#Naming
The directories src/dtm/tools and src/dtm/transport had two cpplint
warnings before your patch (and both of these warnings were false
positives):
src/dtm/tools/osaflog.cc:224: Missing space before {
[whitespace/braces] [5]
src/dtm/transport/log_writer.cc:46: Missing space before {
[whitespace/braces] [5]
With your patch, I get the following cpplint warnings in the same two
directories:
src/dtm/transport/log_server.h:36: Lines should be <= 80 characters
long [whitespace/line_length] [2]
src/dtm/transport/log_server.h:53: Lines should be <= 80 characters
long [whitespace/line_length] [2]
src/dtm/transport/log_writer.h:32: Lines should be <= 80 characters
long [whitespace/line_length] [2]
src/dtm/tools/osaflog.cc:68: Missing spaces around =
[whitespace/operators] [4]
src/dtm/tools/osaflog.cc:70: Missing spaces around =
[whitespace/operators] [4]
src/dtm/tools/osaflog.cc:83: Missing space after , [whitespace/comma] [3]
src/dtm/tools/osaflog.cc:84: Extra space before ) [whitespace/parens] [2]
src/dtm/tools/osaflog.cc:85: Missing space before { [whitespace/braces] [5]
src/dtm/tools/osaflog.cc:110: Missing space before ( in if(
[whitespace/parens] [5]
src/dtm/tools/osaflog.cc:115: Missing space before ( in if(
[whitespace/parens] [5]
src/dtm/tools/osaflog.cc:115: Missing space before else
[whitespace/braces] [5]
src/dtm/tools/osaflog.cc:121: Weird number of spaces at line-start.
Are you using a 2-space indent? [whitespace/indent] [3]
src/dtm/tools/osaflog.cc:121: Missing space before ( in if(
[whitespace/parens] [5]
src/dtm/tools/osaflog.cc:125: Weird number of spaces at line-start.
Are you using a 2-space indent? [whitespace/indent] [3]
src/dtm/tools/osaflog.cc:140: Lines should be <= 80 characters long
[whitespace/line_length] [2]
src/dtm/tools/osaflog.cc:147: Lines should be <= 80 characters long
[whitespace/line_length] [2]
src/dtm/tools/osaflog.cc:171: Lines should be <= 80 characters long
[whitespace/line_length] [2]
src/dtm/tools/osaflog.cc:175: Weird number of spaces at line-start.
Are you using a 2-space indent? [whitespace/indent] [3]
src/dtm/tools/osaflog.cc:175: Lines should be <= 80 characters long
[whitespace/line_length] [2]
src/dtm/tools/osaflog.cc:211: Lines should be <= 80 characters long
[whitespace/line_length] [2]
src/dtm/tools/osaflog.cc:213: Missing space after , [whitespace/comma] [3]
src/dtm/tools/osaflog.cc:214: Missing space before ( in if(
[whitespace/parens] [5]
src/dtm/tools/osaflog.cc:239: Lines should be <= 80 characters long
[whitespace/line_length] [2]
src/dtm/tools/osaflog.cc:243: Lines should be <= 80 characters long
[whitespace/line_length] [2]
src/dtm/tools/osaflog.cc:243: Missing space before else
[whitespace/braces] [5]
src/dtm/tools/osaflog.cc:279: Lines should be <= 80 characters long
[whitespace/line_length] [2]
src/dtm/tools/osaflog.cc:281: Missing space after , [whitespace/comma] [3]
src/dtm/tools/osaflog.cc:282: Missing space before ( in if(
[whitespace/parens] [5]
src/dtm/tools/osaflog.cc:283: Redundant blank line at the start of a
code block should be deleted. [whitespace/blank_line] [2]
src/dtm/tools/osaflog.cc:284: Lines should be <= 80 characters long
[whitespace/line_length] [2]
src/dtm/tools/osaflog.cc:292: Redundant blank line at the start of a
code block should be deleted. [whitespace/blank_line] [2]
src/dtm/tools/osaflog.cc:312: Lines should be <= 80 characters long
[whitespace/line_length] [2]
src/dtm/tools/osaflog.cc:316: Lines should be <= 80 characters long
[whitespace/line_length] [2]
src/dtm/tools/osaflog.cc:352: Lines should be <= 80 characters long
[whitespace/line_length] [2]
src/dtm/tools/osaflog.cc:354: Missing space after , [whitespace/comma] [3]
src/dtm/tools/osaflog.cc:355: Missing space before ( in if(
[whitespace/parens] [5]
src/dtm/tools/osaflog.cc:356: Redundant blank line at the start of a
code block should be deleted. [whitespace/blank_line] [2]
src/dtm/tools/osaflog.cc:357: Lines should be <= 80 characters long
[whitespace/line_length] [2]
src/dtm/tools/osaflog.cc:438: Missing space before {
[whitespace/braces] [5]
src/dtm/transport/log_writer.cc:29: Lines should be <= 80 characters
long [whitespace/line_length] [2]
src/dtm/transport/log_writer.cc:48: Missing space before {
[whitespace/braces] [5]
src/dtm/transport/log_server.cc:21: Found C system header after C++
system header. Should be: log_server.h, c system, c++ system, other.
[build/include_order] [4]
src/dtm/transport/log_server.cc:22: Found C system header after C++
system header. Should be: log_server.h, c system, c++ system, other.
[build/include_order] [4]
src/dtm/transport/log_server.cc:120: Missing spaces around =
[whitespace/operators] [4]
src/dtm/transport/log_server.cc:121: Missing spaces around =
[whitespace/operators] [4]
src/dtm/transport/log_server.cc:127: Redundant blank line at the start
of a code block should be deleted. [whitespace/blank_line] [2]
src/dtm/transport/log_server.cc:128: Missing space after ,
[whitespace/comma] [3]
src/dtm/transport/log_server.cc:146: If an else has a brace on one
side, it should have it on both [readability/braces] [5]
src/dtm/transport/log_server.cc:149: If an else has a brace on one
side, it should have it on both [readability/braces] [5]
src/dtm/transport/log_server.cc:200: Redundant blank line at the start
of a code block should be deleted. [whitespace/blank_line] [2]
src/dtm/transport/log_server.cc:202: Missing space after ,
[whitespace/comma] [3]
src/dtm/transport/log_server.cc:216: Lines should be <= 80 characters
long [whitespace/line_length] [2]
src/dtm/transport/log_server.cc:216: Missing space after ,
[whitespace/comma] [3]
src/dtm/transport/log_server.cc:217: Redundant blank line at the start
of a code block should be deleted. [whitespace/blank_line] [2]
src/dtm/transport/log_server.cc:219: Missing space after ,
[whitespace/comma] [3]
src/dtm/transport/log_server.cc:221: Missing space before ( in if(
[whitespace/parens] [5]
src/dtm/transport/log_server.cc:224: If an else has a brace on one
side, it should have it on both [readability/braces] [5]
src/dtm/transport/log_server.cc:224: If/else bodies with multiple
statements require braces [readability/braces] [4]
src/dtm/transport/log_server.cc:224: Missing space before else
[whitespace/braces] [5]
src/dtm/transport/log_server.cc:225: Missing space before ( in if(
[whitespace/parens] [5]
src/dtm/transport/log_server.cc:228: If an else has a brace on one
side, it should have it on both [readability/braces] [5]
src/dtm/transport/log_server.cc:228: Missing space before else
[whitespace/braces] [5]
src/dtm/transport/log_server.cc:229: Missing space before ( in if(
[whitespace/parens] [5]
src/dtm/transport/log_server.cc:237: Lines should be <= 80 characters
long [whitespace/line_length] [2]
src/dtm/transport/main.cc:30: Lines should be <= 80 characters long
[whitespace/line_length] [2]
regards,
Anders Widell
On 02/12/2018 01:16 PM, syam-talluri wrote:
Summary: dtm: configure trace file size and no of backups in transportd.conf
[#2731]
Review request for Ticket(s): 2731
Peer Reviewer(s):anders.wid...@ericsson.com
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2731
Base revision: a2ee56579bb33a05477b151c15d17f3b12025cf8
Personal repository: git://git.code.sf.net/u/syam-talluri/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs y
Build system y
RPM/packaging y
Configuration files y
Startup scripts n
SAF services n
OpenSAF services y
Core libraries y
Samples n
Tests n
Other n
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
dtm: Added following options --max-backups and --max-file-size to osaflog tool
and in implemented the
functionality in the transportd. The messaging format between osaflog and
transportd is modified by
introducing a structure.
revision b289abf08100596c382765c82c94763ac486731e
Author: syam-talluri <syam.tall...@oracle.com>
Date: Mon, 12 Feb 2018 17:29:26 +0530
dtm: Added following options --max-backups and --max-file-size to osaflog tool
and in transportd [#2731]
revision 0723340e8f4802e82655037e8d2743dddc684180
Author: syam-talluri <syam.tall...@oracle.com>
Date: Mon, 12 Feb 2018 17:29:26 +0530
dtm: configure trace file size and no of backups in transportd.conf [#2731]
Added Files:
------------
src/dtm/transport/transportd.conf
Complete diffstat:
------------------
opensaf.spec.in | 2 +
src/dtm/Makefile.am | 3 +
src/dtm/common/osaflog_protocol.h | 15 ++
src/dtm/tools/osaflog.cc | 262 ++++++++++++++++++++++++++---
src/dtm/transport/log_server.cc | 113 +++++++++++--
src/dtm/transport/log_server.h | 14 +-
src/dtm/transport/log_writer.cc | 6 +-
src/dtm/transport/log_writer.h | 4 +-
src/dtm/transport/main.cc | 3 +
src/dtm/transport/osaf-transport.in | 1 +
src/dtm/transport/tests/log_writer_test.cc | 2 +-
src/dtm/transport/transportd.conf | 13 ++
12 files changed, 391 insertions(+), 47 deletions(-)
Testing Commands:
-----------------
Run osaflog command tool and tryied the --max-file-size=8 and --max--backups=9
Testing, Expected Results:
--------------------------
*** PASTE COMMAND OUTPUTS / TEST RESULTS ***
Conditions of Submission:
-------------------------
*** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC ***
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
