Ack, code review only

Regards,
Ravi

----- Original Message -----
From: gary....@dektech.com.au
To: hans.nordeb...@ericsson.com, minh.c...@dektech.com.au, 
ravisekhar.ko...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net, gary....@dektech.com.au
Sent: Monday, February 19, 2018 7:42:15 AM GMT +05:30 Chennai, Kolkata, Mumbai, 
New Delhi
Subject: [PATCH 1/1] amfnd: remove duplicate log entry [#2783]

---
 src/amf/amfnd/err.cc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/amf/amfnd/err.cc b/src/amf/amfnd/err.cc
index a0529b96c..1d6eb3757 100644
--- a/src/amf/amfnd/err.cc
+++ b/src/amf/amfnd/err.cc
@@ -458,9 +458,6 @@ uint32_t avnd_err_process(AVND_CB *cb, AVND_COMP *comp,
   // add an entry to syslog if recovery method has changed
   log_recovery_escalation(*comp, previous_esc_rcvr, esc_rcvr);
 
-  LOG_NO("'%s' faulted due to '%s' : Recovery is '%s'", comp->name.c_str(),
-         g_comp_err[err_info->src], g_comp_rcvr[esc_rcvr - 1]);
-
   if (((comp->su->is_ncs == true) && (esc_rcvr != SA_AMF_COMPONENT_RESTART)) ||
       esc_rcvr == SA_AMF_NODE_FAILFAST) {
     LOG_ER("%s Faulted due to:%s Recovery is:%s", comp->name.c_str(),
@@ -478,6 +475,9 @@ uint32_t avnd_err_process(AVND_CB *cb, AVND_COMP *comp,
     }
   }
 
+  LOG_NO("'%s' faulted due to '%s' : Recovery is '%s'", comp->name.c_str(),
+         g_comp_err[err_info->src], g_comp_rcvr[esc_rcvr - 1]);
+
   /* execute the recovery */
   rc = avnd_err_recover(cb, comp->su, comp, esc_rcvr);
 
-- 
2.14.1


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to