Summary: ntf: handle try again for ntftest [#2766] Review request for Ticket(s): 2766 Peer Reviewer(s): Minh Pull request to: Minh Affected branch(es): develop, release Development branch: ticket-2766 Base revision: 5629f554686a498f328e0c79fc946379cbcf6967 Personal repository: git://git.code.sf.net/u/canht32/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n NOTE: Patch(es) contain lines longer than 80 characers Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 32f87daf45ecf733fde043aec6f63c6fd230f288 Author: Canh Van Truong <[email protected]> Date: Tue, 27 Feb 2018 18:45:23 +0700 ntf: fix cpplint and cppcheck for ntftest after convert to C++ [#2766] revision ee64c2b695df0662b5e77f705a6b235278b73fdd Author: Canh Van Truong <[email protected]> Date: Tue, 27 Feb 2018 18:44:58 +0700 ntf: handle try again for ntftest [#2766] Handle try_again to ntf API for ntftest that uses C++ decorator "/src/base/try_again_decorator.h" revision a1dc1a86cfe1adbb98210e841da9153f724aab76 Author: Canh Van Truong <[email protected]> Date: Tue, 27 Feb 2018 18:44:42 +0700 ntf: align and replace tab by space [#2766] revision 45142f24d53bd7a3479c66c785fe8eef369eb4ec Author: Canh Van Truong <[email protected]> Date: Tue, 27 Feb 2018 18:44:22 +0700 ntf: Convert to C++ [#2766] Added Files: ------------ src/ntf/apitest/ntf_api_with_try_again.h Complete diffstat: ------------------ src/ntf/Makefile.am | 79 +- src/ntf/apitest/ntf_api_with_try_again.h | 76 + src/ntf/apitest/{sa_error.c => sa_error.cc} | 306 +- src/ntf/apitest/test_ntfFilterVerification.c | 2912 --------- src/ntf/apitest/test_ntfFilterVerification.cc | 2513 ++++++++ src/ntf/apitest/test_ntf_imcn.c | 6343 -------------------- src/ntf/apitest/test_ntf_imcn.cc | 6236 +++++++++++++++++++ src/ntf/apitest/test_ntf_imcn.h | 9 +- .../apitest/tet_NotificationContentVerification.c | 981 --- .../apitest/tet_NotificationContentVerification.cc | 917 +++ src/ntf/apitest/tet_coldsync.c | 901 --- src/ntf/apitest/tet_coldsync.cc | 900 +++ src/ntf/apitest/tet_longDnObject_notification.c | 1302 ---- src/ntf/apitest/tet_longDnObject_notification.cc | 1249 ++++ src/ntf/apitest/tet_ntf.h | 9 +- src/ntf/apitest/tet_ntf_api_wrapper.c | 406 -- src/ntf/apitest/tet_ntf_api_wrapper.cc | 383 ++ src/ntf/apitest/tet_ntf_clm.c | 560 -- src/ntf/apitest/tet_ntf_clm.cc | 524 ++ src/ntf/apitest/tet_ntf_common.c | 1472 ----- src/ntf/apitest/tet_ntf_common.cc | 1446 +++++ src/ntf/apitest/tet_ntf_common.h | 21 +- src/ntf/apitest/tet_ntf_main.c | 194 - src/ntf/apitest/tet_ntf_main.cc | 187 + .../apitest/tet_saNtfAlarmNotificationAllocate.c | 216 - .../apitest/tet_saNtfAlarmNotificationAllocate.cc | 212 + .../tet_saNtfAlarmNotificationFilterAllocate.c | 125 - .../tet_saNtfAlarmNotificationFilterAllocate.cc | 120 + src/ntf/apitest/tet_saNtfArrayValAllocate.c | 219 - src/ntf/apitest/tet_saNtfArrayValAllocate.cc | 212 + src/ntf/apitest/tet_saNtfArrayValGet.c | 371 -- src/ntf/apitest/tet_saNtfArrayValGet.cc | 355 ++ .../tet_saNtfAttributeChangeNotificationAllocate.c | 173 - ...tet_saNtfAttributeChangeNotificationAllocate.cc | 170 + ...aNtfAttributeChangeNotificationFilterAllocate.c | 118 - ...NtfAttributeChangeNotificationFilterAllocate.cc | 111 + src/ntf/apitest/tet_saNtfDispatch.c | 54 - src/ntf/apitest/tet_saNtfDispatch.cc | 51 + src/ntf/apitest/tet_saNtfFinalize.c | 174 - src/ntf/apitest/tet_saNtfFinalize.cc | 166 + src/ntf/apitest/tet_saNtfInitialize.c | 158 - src/ntf/apitest/tet_saNtfInitialize.cc | 145 + .../tet_saNtfMiscellaneousNotificationAllocate.c | 228 - .../tet_saNtfMiscellaneousNotificationAllocate.cc | 229 + src/ntf/apitest/tet_saNtfNotificationCallbackT.c | 512 -- src/ntf/apitest/tet_saNtfNotificationCallbackT.cc | 505 ++ .../tet_saNtfNotificationDiscardedCallbackT.c | 241 - .../tet_saNtfNotificationDiscardedCallbackT.cc | 237 + .../apitest/tet_saNtfNotificationReadFinalize.c | 92 - .../apitest/tet_saNtfNotificationReadFinalize.cc | 87 + .../apitest/tet_saNtfNotificationReadInitialize.c | 383 -- .../apitest/tet_saNtfNotificationReadInitialize.cc | 361 ++ src/ntf/apitest/tet_saNtfNotificationReadNext.c | 424 -- src/ntf/apitest/tet_saNtfNotificationReadNext.cc | 414 ++ src/ntf/apitest/tet_saNtfNotificationSend.c | 909 --- src/ntf/apitest/tet_saNtfNotificationSend.cc | 895 +++ src/ntf/apitest/tet_saNtfNotificationSubscribe.c | 235 - src/ntf/apitest/tet_saNtfNotificationSubscribe.cc | 227 + src/ntf/apitest/tet_saNtfNotificationUnsubscribe.c | 153 - .../apitest/tet_saNtfNotificationUnsubscribe.cc | 148 + ...t_saNtfObjectCreateDeleteNotificationAllocate.c | 225 - ..._saNtfObjectCreateDeleteNotificationAllocate.cc | 222 + ...fObjectCreateDeleteNotificationFilterAllocate.c | 96 - ...ObjectCreateDeleteNotificationFilterAllocate.cc | 91 + src/ntf/apitest/tet_saNtfPtrValAllocate.c | 216 - src/ntf/apitest/tet_saNtfPtrValAllocate.cc | 211 + src/ntf/apitest/tet_saNtfPtrValGet.c | 351 -- src/ntf/apitest/tet_saNtfPtrValGet.cc | 335 ++ .../tet_saNtfSecurityAlarmNotificationAllocate.c | 157 - .../tet_saNtfSecurityAlarmNotificationAllocate.cc | 154 + ..._saNtfSecurityAlarmNotificationFilterAllocate.c | 98 - ...saNtfSecurityAlarmNotificationFilterAllocate.cc | 93 + src/ntf/apitest/tet_saNtfSelectionObjectGet.c | 72 - src/ntf/apitest/tet_saNtfSelectionObjectGet.cc | 68 + .../tet_saNtfStateChangeNotificationAllocate.c | 172 - .../tet_saNtfStateChangeNotificationAllocate.cc | 168 + ...et_saNtfStateChangeNotificationFilterAllocate.c | 103 - ...t_saNtfStateChangeNotificationFilterAllocate.cc | 96 + src/ntf/apitest/tet_scOutage_reinitializeHandle.c | 1191 ---- src/ntf/apitest/tet_scOutage_reinitializeHandle.cc | 1143 ++++ 80 files changed, 21859 insertions(+), 22759 deletions(-) Testing Commands: ----------------- All test cases are updated Testing, Expected Results: -------------------------- Run all test case pass Conditions of Submission: ------------------------- Ack from reviewers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
