Summary: imm: improve cascade delete [#2667]
Review request for Ticket(s): 2667
Peer Reviewer(s): *** Ravi, Hans, Anders, Lennart, Zoran
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2667
Base revision: 30b70f4a56ab0225d3ade3cc8dda3fe403b5492c
Personal repository: git://git.code.sf.net/u/winhvu/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
Send for review on Zoran's behalf.
There is performance degradation in previous patch, this patch is the
replacement.
revision ad8765987d64f18df9c6eb7002d930c40d032c5e
Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>
Date: Mon, 12 Mar 2018 09:48:31 +0700
imm: improve cascade delete [#2667]
When an object is deleted, and the object has children, the delete meesage is
sent for each deleted object to PBE. Since there are a lot of messages in the
cascade delete from IMMND to PBE at once, there is a limitation that the cascade
delete should not be done on object that contains more than 10000 object. More
than 10000 object may cause buffer overload (e.g. TIPC_ERR_OVERLOAD), and
messages might be lost.
The improvement should send only one message to PBE which will contain only the
root object. The rest of cascade delete will be on PBE side.
Complete diffstat:
------------------
src/imm/common/immpbe_dump.cc | 548 ++++++++++++++++++++++++++++++------------
src/imm/immnd/ImmModel.cc | 18 +-
src/imm/immnd/ImmModel.h | 3 +-
src/imm/immnd/immnd_evt.c | 210 ++++++++--------
4 files changed, 508 insertions(+), 271 deletions(-)
Testing Commands:
-----------------
Using TIPC, create around 200K objects with same parent,
then do delete the parent object (cascade delete)
Testing, Expected Results:
--------------------------
No TIPC_ERR_OVERLOAD
Conditions of Submission:
-------------------------
Ack from peer reviewers.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
