Hi Lennart, Ack
Thanks Canh -----Original Message----- From: Lennart Lund [mailto:lennart.l...@ericsson.com] Sent: Friday, March 9, 2018 9:50 PM To: vu.m.ngu...@dektech.com.au; canh.v.tru...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net; Lennart Lund <lennart.l...@ericsson.com> Subject: [PATCH 0/1] Review Request for log: Fix cyclic crash when starting standby and OI is not active [#2711] Summary: log: Fix cyclic crash when starting standby and OI is not active [#2711] Review request for Ticket(s): 2711 Peer Reviewer(s): canh.v.tru...@dektech.com.au, vu.m.ngu...@dektech.com.au Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2711 Base revision: 30b70f4a56ab0225d3ade3cc8dda3fe403b5492c Personal repository: git://git.code.sf.net/u/elunlen/review -------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- Added fix to make full compatibility between this and older version regarding message based checkpointing revision 0297bb21730490bbfa003eec2adf3b9de112f2cf Author: Lennart Lund <lennart.l...@ericsson.com> Date: Fri, 9 Mar 2018 15:39:37 +0100 log: Fix cyclic crash when starting standby and OI is not active [#2711] Fix cyclic reboot caused by reading an IMM RT object when the OI is down Complete diffstat: ------------------ src/log/apitest/logtest.c | 2 -- src/log/logd/lgs_config.cc | 2 +- src/log/logd/lgs_evt.cc | 13 +++++------ src/log/logd/lgs_fmt.h | 8 ++++++- src/log/logd/lgs_imm.cc | 13 ++++++----- src/log/logd/lgs_mbcsv.cc | 56 +++++++++++++++++++++++++++++++++------------- src/log/logd/lgs_mbcsv.h | 7 +++++- src/log/logd/lgs_recov.cc | 6 +++-- src/log/logd/lgs_stream.cc | 28 +++++++++-------------- src/log/logd/lgs_stream.h | 2 +- src/osaf/immutil/immutil.h | 4 +++- 11 files changed, 87 insertions(+), 54 deletions(-) Testing Commands: ----------------- *** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES *** Testing, Expected Results: -------------------------- *** PASTE COMMAND OUTPUTS / TEST RESULTS *** Conditions of Submission: ------------------------- *** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC *** Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
