Hi Hans, See my response inline.
Regards, Vu > -----Original Message----- > From: Hans Nordebäck [mailto:[email protected]] > Sent: Wednesday, March 14, 2018 9:14 PM > To: Vu Minh Nguyen <[email protected]>; > [email protected]; [email protected]; > [email protected]; [email protected] > Cc: [email protected] > Subject: Re: [PATCH 1/1] imm: fix unknown event type in > imma_proc_free_pointers [#2779] > > ack, review only. One question below. > > /Thanks HansN > > > On 03/13/2018 08:19 AM, Vu Minh Nguyen wrote: > > The message type IMMA_EVT_ND2A_PROC_STALE_CLIENTS was introduced > in IMM, > > but missed mention it in `void imma_proc_free_pointers()`. > > --- > > src/imm/agent/imma_proc.cc | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/src/imm/agent/imma_proc.cc b/src/imm/agent/imma_proc.cc > > index 886b50c..ec62b98 100644 > > --- a/src/imm/agent/imma_proc.cc > > +++ b/src/imm/agent/imma_proc.cc > > @@ -1401,6 +1401,9 @@ void imma_proc_free_pointers(IMMA_CB *cb, > IMMA_EVT *evt) { > > case IMMA_EVT_ND2A_OI_CCB_ABORT_UC: > > break; > > > > + case IMMA_EVT_ND2A_PROC_STALE_CLIENTS: > [HansN] why isn't this case stmt added to the case stmt's before, such as: > > case IMMA_EVT_ND2A_OI_CCB_COMPLETED_UC: > case IMMA_EVT_ND2A_OI_CCB_APPLY_UC: > case IMMA_EVT_ND2A_OI_CCB_ABORT_UC: > case IMMA_EVT_ND2A_PROC_STALE_CLIENTS: [Vu] XXX_OI_CCB_XXX message types belongs to CCB up call category/group while XXX_PROC_STALE_XXX doesn't. So, separate them to different code blocks may be better, I think. > break; > > + break; > > + > > default: > > TRACE_4("Unknown event type %u", evt->type); > > break; ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
