Hi Srinivas,

       Two comments:
    1. Put the new include file before the above "msg/..." files, so it is
       in alphabetical order
    2. change the test, so there is only one aisrc_validate call in it.
       Otherwise, 2 PASSED show up for the test.

   Alex

   On 03/26/2018 07:23 AM, srinivas wrote:
     __________________________________________________________________

   NOTICE: This email was received from an EXTERNAL sender
     __________________________________________________________________

   ---
   src/msg/apitest/test_MetaDataSize.cc | 6 +++++-
   1 file changed, 5 insertions(+), 1 deletion(-)
   diff --git a/src/msg/apitest/test_MetaDataSize.cc
   b/src/msg/apitest/test_MetaDataSize.cc
   index f99b02b..6d7375a 100644
   --- a/src/msg/apitest/test_MetaDataSize.cc
   +++ b/src/msg/apitest/test_MetaDataSize.cc
   @@ -10,6 +10,7 @@
   #include "msg/apitest/tet_mqsv.h"
   #include <saMsg.h>
   #include <saNtf.h>
   +#include "msg/agent/mqa.h"
   static SaVersionT msg3_1 = {'B', 3, 0};
   @@ -67,7 +68,10 @@ static void metaDataSize_05(void) {
   rc = saMsgMetadataSizeGet(msgHandle, &metaDataSize);
   aisrc_validate(rc, SA_AIS_OK);
   - assert(metaDataSize == 344);
   + if (metaDataSize != sizeof(MQSV_MESSAGE) +
   + sizeof(NCS_OS_MQ_MSG_LL_HDR))
   + rc = SA_AIS_ERR_MESSAGE_ERROR;
   + aisrc_validate(rc, SA_AIS_OK);
   rc = saMsgFinalize(msgHandle);
   assert(rc == SA_AIS_OK);
   --
   2.7.4

Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to