Summary: base: Re-factor the timer implementation [#2440]
Review request for Ticket(s): 2440
Peer Reviewer(s): Ravi
Pull request to: 
Affected branch(es): develop
Development branch: ticket-2440
Base revision: b83be452a25a37c7f5b568b436d1af544afb7350
Personal repository: git://

Impacted area       Impact y/n
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            n
 OpenSAF services        n
 Core libraries          y
 Samples                 n
 Tests                   n
 Other                   n

Comments (indicate scope for each "y" above):

revision 49be7d5f610fb7e23d8df575007fa3b21a5e0946
Author: Anders Widell <>
Date:   Mon, 9 Apr 2018 16:10:41 +0200

base: Re-factor the timer implementation [#2440]

Re-factor the NCS timer implementation and provide the AIS TMR API as an
alternative way to use the timer implementation, alongside with the old NCS
API. The AIS TMR API is intended for internal use in OpenSAF services for now,
but it could be exported as an official OpenSAF API later if it turns out to be
working well. OpenSAF services using the TMR API instead of the NCS API will no
longer need a dedicated timer thread.

The new timer implementation is using a C++ STL multiset for the timer queue,
and a Linux timerfd for the selection object.

Added Files:

Removed Files:

Complete diffstat:
------------------               |   12 +
 src/ais/              |    3 +
 src/ais/include/saTmr.h          |  148 ++++++
 src/base/             |   13 +-
 src/base/handle/external_mutex.h |   66 +++
 src/base/handle/        |   63 +++
 src/base/handle/handle.h         |  107 ++++
 src/base/handle/object.h         |   52 ++
 src/base/handle/     |   91 ++++
 src/base/handle/object_db.h      |  109 ++++
 src/base/          |  254 +++++++++
 src/base/ncssysf_tmr.h           |  135 +++--
 src/base/ncssysf_tsk.h           |    4 +-
 src/base/sysf_tmr.c              | 1085 --------------------------------------
 src/base/tests/    | 1079 +++++++++++++++++++++++++++++++++++++
 src/base/tests/  |  205 +++++--
 src/base/timer/          |  569 ++++++++++++++++++++
 src/base/timer/timer.h           |   55 ++
 src/base/timer/   |  190 +++++++
 src/base/timer/timer_handle.h    |  101 ++++
 20 files changed, 3149 insertions(+), 1192 deletions(-)

Testing Commands:

make check

Testing, Expected Results:

Unit tests shall pass

Conditions of Submission:

Ack from reviewer(s), or on 2018-04-16 if no comments have been received.

Arch      Built     Started    Linux distro
mips        n          n
mips64      n          n
x86         n          n
x86_64      y          y
powerpc     n          n
powerpc64   n          n

Reviewer Checklist:
[Submitters: make sure that your review doesn't trigger any checkmarks!]

Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.gitconfig file (i.e., etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.

Check out the vibrant tech community on one of the world's most
engaging tech sites,!
Opensaf-devel mailing list

Reply via email to