Summary: clmd: pass rootCauseEntity from PLM tracking to CLM tracking clients
[#2834]
Review request for Ticket(s): 2834
Peer Reviewer(s): Anders, Mathi
Pull request to:
Affected branch(es): develop
Development branch: ticket-2834
Base revision: aff54ff091727f27830443332b830890668749cf
Personal repository: git://git.code.sf.net/u/trguitar/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
revision 62589757a43679a24bc4c1f863a68346a23b5a37
Author: Alex Jones <ajo...@rbbn.com>
Date: Thu, 12 Apr 2018 10:53:19 -0400
clmd: pass rootCauseEntity from PLM tracking to CLM tracking clients [#2834]
CLM tracking clients have no context for the tracking callback.
PLM rootCauseEntity is not passed by CLM to its own tracking clients.
When CLM tracking is invoked because of PLM tracking, pass on the
rootCauseEntity.
Complete diffstat:
------------------
src/clm/clmd/clms_evt.cc | 4 +--
src/clm/clmd/clms_imm.cc | 80 ++++++++++++++++++++++++++++++-----------------
src/clm/clmd/clms_imm.h | 9 ++++--
src/clm/clmd/clms_plm.cc | 3 +-
src/clm/clmd/clms_util.cc | 13 ++++----
5 files changed, 69 insertions(+), 40 deletions(-)
Testing Commands:
-----------------
1) Create a CLM tracking client.
2) Using PLM, lock a parent (host) EE, that also has child EEs.
Testing, Expected Results:
--------------------------
1) rootCauseEntity of host should be passed in the tracking callback
2) all EEs (child and parent) should be present in the notification
Conditions of Submission:
-------------------------
Apr 18 or ack from developer
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
