Summary: base: Add support for setting UnixServerSocket file permissions [#2838]
Review request for Ticket(s): 2838
Peer Reviewer(s): Ravi
Pull request to: 
Affected branch(es): develop
Development branch: ticket-2838
Base revision: b13a65123bfddcc6f5105fe340131e3bd8a5ac70
Personal repository: git://git.code.sf.net/u/anders-w/review

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            n
 OpenSAF services        y
 Core libraries          y
 Samples                 n
 Tests                   n
 Other                   n


Comments (indicate scope for each "y" above):
---------------------------------------------

revision 5dcaf67087e852a9682d00c481351fd51faef268
Author: Anders Widell <anders.wid...@ericsson.com>
Date:   Fri, 13 Apr 2018 15:15:16 +0200

dtm: Make the osaftransportd socket world-writable [#2838]

Allow OpenSAF agent libraries running in application processes to send trace
messages to osaftransportd, regardless of what user-id and group-id the
application process is running with.



revision 2713c82f25d9dfdaa988819ef0fde2a0942369f9
Author: Anders Widell <anders.wid...@ericsson.com>
Date:   Fri, 13 Apr 2018 13:55:50 +0200

base: Add support for setting UnixServerSocket file permissions [#2838]



Complete diffstat:
------------------
 src/base/unix_server_socket.cc  | 14 +++++++++++---
 src/base/unix_server_socket.h   |  7 +++++--
 src/dtm/transport/log_server.cc |  3 ++-
 3 files changed, 18 insertions(+), 6 deletions(-)


Testing Commands:
-----------------

ls -l /var/lib/opensaf


Testing, Expected Results:
--------------------------

/var/lib/opensaf/osaf_log.sock shall be world-writable.


Conditions of Submission:
-------------------------

Ack from reviewer(s), or on 2018-04-19


Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      y          y
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to