Summary: base: Add support to direct OpenSAF logging to local node file V3
[#2306]
Review request for Ticket(s): 2306
Peer Reviewer(s): Anders, Hans, Ravi
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2306
Base revision: 72b6ed1fdd6851d8af6bb3dcd2fea25d8095ad1e
Personal repository: git://git.code.sf.net/u/minh-chau/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries y
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
This V3 moves the TraceLog into new file
logtrace_client.h/cc
revision 30417b4eced76c5cc924cc2ec96a10c241da0011
Author: Minh Chau <minh.c...@dektech.com.au>
Date: Fri, 20 Apr 2018 09:29:41 +1000
base: Add OSAF_LOCAL_NODE_LOG environment variable to osaf service conf file
[#2306]
revision 26be4c6c2fe33b8b92d4c2d46c02ad50c39896c7
Author: Minh Chau <minh.c...@dektech.com.au>
Date: Fri, 20 Apr 2018 09:28:35 +1000
base: Add support to direct OpenSAF logging to local node file V3 [#2306]
Unify TraceLog and MdsLog class to one class (TraceLog) so it can be
used as a common log client.
Add new instance TraceLog for OpenSAF logging to local file, which can
be enabled/disabled via environment variable OSAF_LOCAL_NODE_LOG.
Added Files:
------------
src/base/logtrace_client.cc
src/base/logtrace_client.h
Complete diffstat:
------------------
src/amf/amfd/amfd.conf | 5 ++
src/amf/amfnd/amfnd.conf | 5 ++
src/amf/amfwd/amfwdog.conf | 5 ++
src/base/Makefile.am | 2 +
src/base/logtrace.cc | 195 ++++++++++++--------------------------------
src/base/logtrace.h | 12 ++-
src/base/logtrace_client.cc | 105 ++++++++++++++++++++++++
src/base/logtrace_client.h | 55 +++++++++++++
src/ckpt/ckptd/ckptd.conf | 5 ++
src/ckpt/ckptnd/ckptnd.conf | 5 ++
src/clm/clmd/clmd.conf | 5 ++
src/clm/clmnd/clmna.conf | 5 ++
src/dtm/dtmnd/dtmd.conf | 5 ++
src/evt/evtd/evtd.conf | 5 ++
src/fm/fmd/fmd.conf | 5 ++
src/imm/immd/immd.conf | 4 +
src/imm/immnd/immnd.conf | 5 ++
src/lck/lckd/lckd.conf | 5 ++
src/lck/lcknd/lcknd.conf | 5 ++
src/log/logd/logd.conf | 5 ++
src/mds/mds_log.cc | 132 +++---------------------------
src/msg/msgd/msgd.conf | 5 ++
src/msg/msgnd/msgnd.conf | 5 ++
src/ntf/ntfd/ntfd.conf | 5 ++
src/plm/plmd/plmd.conf | 5 ++
src/rde/rded/rde.conf | 5 ++
src/smf/smfd/smfd.conf | 5 ++
src/smf/smfnd/smfnd.conf | 5 ++
28 files changed, 343 insertions(+), 267 deletions(-)
Testing Commands:
-----------------
*** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES ***
Testing, Expected Results:
--------------------------
*** PASTE COMMAND OUTPUTS / TEST RESULTS ***
Conditions of Submission:
-------------------------
ack from reviewers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
