Summary: lck: resurrect apitests [#2437]
Review request for Ticket(s): 2437
Peer Reviewer(s): Ravi
Pull request to:
Affected branch(es): develop
Development branch: ticket-2437
Base revision: b05d3f7ab7b88662a89c3493767969f6c890dc95
Personal repository: git://git.code.sf.net/u/trguitar/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests y
Other n
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
These checkins resurrect the apitest for LCK.
revision 494407c7d28526ac0d616f9be8c2484981bbbeda
Author: Alex Jones <ajo...@rbbn.com>
Date: Fri, 27 Apr 2018 14:37:12 -0400
lck: resurrect apitest [#2437]
Resurrect apitest
revision 106200a751299a2adf20574809845098e055b874
Author: Alex Jones <ajo...@rbbn.com>
Date: Fri, 27 Apr 2018 14:29:53 -0400
lck: resurrect apitest [#2437]
Resurrect apitest
revision 79ecd8f8dee2a66472df23eb99d9e6b8bdc72856
Author: Alex Jones <ajo...@rbbn.com>
Date: Fri, 27 Apr 2018 14:29:53 -0400
lck: resurrect apitests [#2437]
Resurrect apitests
revision 602a7774266651c429d672a4a7d26d46ab989909
Author: Alex Jones <ajo...@rbbn.com>
Date: Fri, 27 Apr 2018 14:29:53 -0400
lck: resurrect apitests [#2437]
Resurrect apitests
Added Files:
------------
src/lck/apitest/lcktest.c
src/lck/apitest/lcktest.h
src/lck/apitest/Makefile
src/lck/apitest/test_ErrUnavailable.cc
src/lck/apitest/test_saLckLimitGet.cc
src/lck/apitest/test_saLckResourceClass.cc
Complete diffstat:
------------------
src/lck/Makefile.am | 22 +-
src/lck/apitest/Makefile | 18 +
src/lck/apitest/lcktest.c | 42 +
src/lck/apitest/lcktest.h | 30 +
src/lck/apitest/test_ErrUnavailable.cc | 1265 +++++++++++++++++++
src/lck/apitest/test_saLckLimitGet.cc | 423 +++++++
src/lck/apitest/test_saLckResourceClass.cc | 1892 ++++++++++++++++++++++++++++
src/lck/apitest/tet_gla.c | 735 +++--------
src/lck/apitest/tet_gla_conf.c | 229 +---
src/lck/apitest/tet_glsv.h | 39 +-
src/lck/apitest/tet_glsv_util.c | 576 ++++++++-
src/lck/lckd/gld_mds.c | 3 -
12 files changed, 4411 insertions(+), 863 deletions(-)
Testing Commands:
-----------------
1) run lcktest
Testing, Expected Results:
--------------------------
1) all tests pass
Conditions of Submission:
-------------------------
May 3, or ack from developer
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
