Summary: ntf: Don't use old style SaNameT with 255 chars DN in ntfimcnd [#2850] Review request for Ticket(s): 2850 Peer Reviewer(s): Minh, Srinivas, Lennart Pull request to: Minh, Srinivas, Lennart Affected branch(es): develop Development branch: ticket-2850 Base revision: 93e2808fb0bd3143a77e31dd2f0115a6596479ed Personal repository: git://git.code.sf.net/u/xhoalee/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services y Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- revision d20beaf07cdbfc56009ff2a02f900b65607dc060 Author: Hoa Le <[email protected]> Date: Mon, 14 May 2018 15:52:10 +0700 ntf: Don't use old style SaNameT with 255 chars DN in ntfimcnd [#2850] osafntfimcnd uses old style SaNameT when sending notification. The SaNameT's length will be adjusted to 256 when it's value contains 255 characters excluded the NULL character. This SaNameT is now not a valid extended name and causes osafntfimcnd to exit. This patch helps avoid the above issue by using the new style of SaNameT if the SaNameT' value is a 255 chars DN. Complete diffstat: ------------------ src/ntf/common/ntfsv_mem.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) Testing Commands: ----------------- 1. Create a class with NOTIFY flag. 2. Create an object of this class with 255 chars DN. 3. Observe the error messages of osafntfimcnd in system logs. Testing, Expected Results: -------------------------- - osafntfimcnd doesn't exit. - There is an SA_NTF_OBJECT_CREATION notification of the 255 chars DN object. Conditions of Submission: ------------------------- ACK from reviewer. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
