Summary: base: Support thread trace buffer [#456]
Review request for Ticket(s): 456
Peer Reviewer(s): Anders, Hans, Ravi
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-456
Base revision: efdaba75b5cc3b1625d24c9a2ecefe1a3ca9b2c4
Personal repository: git://git.code.sf.net/u/minh-chau/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries y
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
The amfd.conf will be updated together with
other services' conf file when the patch is
pushed
revision 725e4a55e60cd777a8068786ef525ac024316671
Author: Minh Chau <minh.c...@dektech.com.au>
Date: Tue, 12 Jun 2018 07:03:15 +1000
base: Support thread trace buffer [#456]
This ticket support the tracing buffer per thread. If enabled,
each thread has it own buffer which the trace is written to.
The thread trace buffers will be flushed to file if an abnormal
end hits, i.e. LOG_ER is called.
The thread trace file format: "daemon_name"_"proc_id"_"thread_id"
is stored under /var/log/opensaf/. These file can be correlated
in timing order by a "sort" command or could be by another saflog
command.
Main changes in this ticket
. Rename LogTrace class to LogTraceClient
. Move Log_Writer from dtm to base
. Add LogTraceBuffer class, this class hold the trace buffer
. Add thread_local instace of LogTraceBuffer, so that the instance
of LogTraceBuffer will be created/deleted whenever a new thread
is created or destroyed.
. Add an instance of LogTraceClient for thread trace buffering.
Added Files:
------------
src/base/logtrace_buffer.cc
src/base/logtrace_buffer.h
src/base/log_writer.cc
src/base/log_writer.h
Removed Files:
--------------
src/dtm/transport/log_writer.cc
src/dtm/transport/log_writer.h
Complete diffstat:
------------------
src/amf/amfd/amfd.conf | 5 ++
src/base/Makefile.am | 4 +
src/base/daemon.c | 3 +
src/base/log_writer.cc | 135 +++++++++++++++++++++++++++++
src/base/log_writer.h | 65 ++++++++++++++
src/base/logtrace.cc | 77 +++++++++++++---
src/base/logtrace.h | 6 ++
src/base/logtrace_buffer.cc | 87 +++++++++++++++++++
src/base/logtrace_buffer.h | 52 +++++++++++
src/base/logtrace_client.cc | 91 ++++++++++++++-----
src/base/logtrace_client.h | 50 ++++++++---
src/dtm/Makefile.am | 3 -
src/dtm/transport/log_server.h | 2 +-
src/dtm/transport/log_writer.cc | 117 -------------------------
src/dtm/transport/log_writer.h | 64 --------------
src/dtm/transport/tests/log_writer_test.cc | 2 +-
src/mds/mds_log.cc | 18 ++--
17 files changed, 537 insertions(+), 244 deletions(-)
Testing Commands:
-----------------
Testing, Expected Results:
--------------------------
thread trace file are stored in /var/log/opensaf
Conditions of Submission:
-------------------------
ack from reviewers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
