Ack. regards, Anders Widell
mån 2018-07-02 klockan 16:15 +0700 skrev Vu Minh Nguyen: > When user enters subject having slash (/) in, submit-review.sh won't > work > with error message: sed: -e expression #1, char 78: unknown option to > `s' > > This patch ensures that all slashes in the input variable $subject > are backslash-escaped. > --- > tools/devel/review/submit-review.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/devel/review/submit-review.sh > b/tools/devel/review/submit-review.sh > index a25d92e15..14431f08e 100755 > --- a/tools/devel/review/submit-review.sh > +++ b/tools/devel/review/submit-review.sh > @@ -453,7 +453,7 @@ done > > "$GIT" format-patch --numbered --cover-letter --subject="PATCH" --to > "$toline" --cc "opensaf-devel@lists.sourceforge.net" -o "$rr" "$rev" > > -sed -i -e "s/\*\*\* SUBJECT HERE \*\*\*/Review Request for > $subject/" "$rr/0000-cover-letter.patch" > +sed -i -e "s/\*\*\* SUBJECT HERE \*\*\*/Review Request for > ${subject//\//\\\/}/" "$rr/0000-cover-letter.patch" > sed -i -e '/^\*\*\* BLURB HERE \*\*\*$/,$d' "$rr/0000-cover- > letter.patch" > cat "$rr/rr.patch" >> "$rr/0000-cover-letter.patch" > rm -f "$rr"/rr.patch* ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel