Hi Danh Vo, Ack with comments.
I have checked comments from Vu and have not duplicated any of those. I do have some additional comments. See attached diff that can be applied on the review branch. Thanks Lennart > -----Original Message----- > From: Danh Vo <danh.c...@dektech.com.au> > Sent: den 1 augusti 2018 10:29 > To: Hans Nordebäck <hans.nordeb...@ericsson.com>; Lennart Lund > <lennart.l...@ericsson.com>; Gary Lee <gary....@dektech.com.au>; Vu > Minh Nguyen <vu.m.ngu...@dektech.com.au> > Cc: opensaf-devel@lists.sourceforge.net; Danh Cong Vo > <danh.c...@dektech.com.au> > Subject: [PATCH 0/1] Review Request for imm: syslog recent fevs evts when > immnd down [#2898] V3 > > Summary: imm: syslog recent fevs evts when immnd down [#2898] > Review request for Ticket(s): 2898 > Peer Reviewer(s): Hans Nordeback, Lennart Lund, Gary Lee, Vu Minh > Nguyen > Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** > Affected branch(es): develop > Development branch: ticket-2898 > Base revision: 7f6f6c0531a0f5e4f2b0dc1abf4bab6962a3d1a9 > Personal repository: git://git.code.sf.net/u/zvoxdan/review > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services n > OpenSAF services y > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** > > revision 6e8b8e238e5a269a052cbad774158c031226676d > Author: Danh Vo <danh.c...@dektech.com.au> > Date: Wed, 1 Aug 2018 15:10:36 +0700 > > imm: syslog recent fevs evts when immnd down [#2898] > > An enhancement for IMM to print out 5 last FEVS events into syslog when > IMMND down for any reason. > > > > Added Files: > ------------ > src/imm/immnd/immnd_utils.cc > src/imm/immnd/immnd_utils.h > > > Complete diffstat: > ------------------ > src/imm/Makefile.am | 4 +- > src/imm/common/immsv_evt.c | 2 +- > src/imm/common/immsv_evt.h | 1 + > src/imm/immnd/immnd_evt.c | 7 ++ > src/imm/immnd/immnd_utils.cc | 201 > +++++++++++++++++++++++++++++++++++++++++++ > src/imm/immnd/immnd_utils.h | 36 ++++++++ > 6 files changed, 249 insertions(+), 2 deletions(-) > > > Testing Commands: > ----------------- > *** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES *** > > > Testing, Expected Results: > -------------------------- > *** PASTE COMMAND OUTPUTS / TEST RESULTS *** > > > Conditions of Submission: > ------------------------- > *** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC *** > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 y y > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your > headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email > etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual.
2898_lennart_comments4.diff
Description: 2898_lennart_comments4.diff
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
