Hi Vu,
Thanks for your comment. I will Incorporate your comment before push.
Thanks
Ratnamala
High Availability Solutions Pvt Ltd
www.hasolutions.in
--------- Original Message --------- Subject: RE: [PATCH 1/1] log: add new test
case of API saLogInitialize() of apitest [#2915]
From: "Vu Minh Nguyen" <vu.m.ngu...@dektech.com.au>
Date: 8/30/18 8:18 am
To: "'Ratnamala Tallari'" <ratnam...@hasolutions.in>, lennart.l...@ericsson.com
Cc: opensaf-devel@lists.sourceforge.net
Hi,
Ack with minor comments.
Thanks, Vu
> -----Original Message-----
> From: Ratnamala Tallari <ratnam...@hasolutions.in>
> Sent: Tuesday, August 28, 2018 7:19 PM
> To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net; Ratnamala Tallari
> <ratnam...@hasolutions.in>
> Subject: [PATCH 1/1] log: add new test case of API saLogInitialize() of
apitest
> [#2915]
>
> ---
> src/log/apitest/tet_saLogInitialize.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/src/log/apitest/tet_saLogInitialize.c
> b/src/log/apitest/tet_saLogInitialize.c
> index 3d31c8e..c4372a7 100644
> --- a/src/log/apitest/tet_saLogInitialize.c
> +++ b/src/log/apitest/tet_saLogInitialize.c
> @@ -107,6 +107,13 @@ void saLogInitialize_11(void)
>
> test_validate(rc, SA_AIS_OK);
> }
> +// Test that SA_AIS_ERR_INVALID_PARAM is returned if version parameter is
> set to a NULL pointer
[Vu] Should limit the line-length to 80 characters.
> +void saLogInitialize_version_NULL_pointer_error (void)
[Vu] Remove a space right after the function name.
> +{
> + rc = saLogInitialize(&logHandle, &logCallbacks, NULL);
> + logFinalize();
> + test_validate(rc, SA_AIS_ERR_INVALID_PARAM);
> +}
>
> extern void saLogSelectionObjectGet_01(void);
> extern void saLogSelectionObjectGet_02(void);
> @@ -139,6 +146,8 @@ __attribute__((constructor)) static void
> saLibraryLifeCycle_constructor(void)
> "saLogInitialize() with minor version is set bigger than
supported
> version");
> test_case_add(1, saLogInitialize_11,
> "saLogInitialize() with minor version is not set");
> + test_case_add(1, saLogInitialize_version_NULL_pointer_error,
> + "saLogInitialize() valid handle, valid callbacks and version
as
> NULL");
> test_case_add(1, saLogSelectionObjectGet_01,
> "saLogSelectionObjectGet() OK");
> test_case_add(1, saLogSelectionObjectGet_02,
> --
> 2.7.4
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
