ack, review only. Minor comment below. /Thanks HansN
On 08/21/2018 03:20 PM, Richa Tiwari wrote:
---
src/clm/apitest/tet_saClmInitialize.cc | 53 ++++++++++++++++++++++++++++++++++
1 file changed, 53 insertions(+)
diff --git a/src/clm/apitest/tet_saClmInitialize.cc
b/src/clm/apitest/tet_saClmInitialize.cc
index b5c4ec0..ce8931e 100644
--- a/src/clm/apitest/tet_saClmInitialize.cc
+++ b/src/clm/apitest/tet_saClmInitialize.cc
@@ -116,6 +116,46 @@ void saClmInitialize_13() {
safassert(ClmTest::saClmFinalize(clmHandle3), SA_AIS_OK);
test_validate(rc, SA_AIS_OK);
}
+
+void saClmInitialize_14()
+{
+ SaClmCallbacksT_4 clmCallbacks_4={nullptr,};
+ rc = ClmTest::saClmInitialize_4(&clmHandle, &clmCallbacks_4,
&clmVersion_4);
[HansN] perhaps check the rc before next line?
+ safassert(ClmTest::saClmFinalize(clmHandle), SA_AIS_OK);
+ test_validate(rc, SA_AIS_OK);
+}
+
+void saClmInitialize_15()
+{
+ rc = ClmTest::saClmInitialize_4(nullptr, nullptr, nullptr);
+ test_validate(rc, SA_AIS_ERR_INVALID_PARAM);
+}
+
+void saClmInitialize_16()
+{
+ rc = ClmTest::saClmInitialize_4(&clmHandle,nullptr, nullptr);
+ test_validate(rc, SA_AIS_ERR_INVALID_PARAM);
+}
+
+void saClmInitialize_17()
+{
+ rc = ClmTest::saClmInitialize_4(nullptr, &clmCallbacks_4, nullptr);
+ test_validate(rc, SA_AIS_ERR_INVALID_PARAM);
+}
+
+void saClmInitialize_18()
+{
+ rc = ClmTest::saClmInitialize_4(nullptr, &clmCallbacks_4,
&clmVersion_4);
+ test_validate(rc, SA_AIS_ERR_INVALID_PARAM);
+}
+
+void saClmInitialize_19()
+{
+ SaClmCallbacksT_4 clmCallbacks_4={nullptr,};
+ rc = ClmTest::saClmInitialize_4(nullptr, &clmCallbacks_4,
&clmVersion_4);
+ test_validate(rc, SA_AIS_ERR_INVALID_PARAM);
+}
+
#if 0
void saClmInitialize_13()
rc = ClmTest::saClmInitialize(&clmHandle, &clmCallbacks_1, &clmVersion_1);
@@ -164,6 +204,19 @@ __attribute__((constructor)) static void
saNtfInitialize_constructor() {
"saClmInitialize & saClmInitialize_4 with B.0.0 version");
test_case_add(1, saClmInitialize_13,
"saClmInitialize with multiple instance");
+ test_case_add(1, saClmInitialize_14,
+ "saClmInitialize_4 with clusterNodeGetCallback as null");
+ test_case_add(1, saClmInitialize_15,
+ "saClmInitialize_4 with all parameters as null");
+ test_case_add(1, saClmInitialize_16,
+ "saClmInitialize_4 with callback & version as null");
+ test_case_add(1, saClmInitialize_17,
+ "saClmInitialize_4 with handle & version as null");
+ test_case_add(1, saClmInitialize_18,
+ "saClmInitialize_4 with handle as null");
+ test_case_add(1, saClmInitialize_19,
+ "saClmInitialize_4 with handle & ClusterNodeGetCallback as
null");
+
#if 0
/* this test case is for SA_AIS_ERR_LIBRARY, which will be passed when tipc
* is running and clma_create() will fail*/
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
