Ack. I will push it.

   Alex

   On 09/11/2018 08:55 AM, Meenakshi TK wrote:
     __________________________________________________________________

   NOTICE: This email was received from an EXTERNAL sender
     __________________________________________________________________

   Summary: plma: align the function headers [#199]
   Review request for Ticket(s): 199
   Peer Reviewer(s): Alex,Mathi
   Pull request to: Alex,Mathi
   Affected branch(es): develop
   Development branch: ticket-199
   Base revision: 1315ade5d2223ecb22cc3076da00d4cee09ec7f7
   Personal repository: [1]git://git.code.sf.net/u/meenatk-hasoln/review
   --------------------------------
   Impacted area Impact y/n
   --------------------------------
   Docs n
   Build system n
   RPM/packaging n
   Configuration files n
   Startup scripts n
   SAF services y
   OpenSAF services n
   Core libraries n
   Samples n
   Tests n
   Other n
   NOTE: Patch(es) contain lines longer than 80 characers
   Comments (indicate scope for each "y" above):
   ---------------------------------------------
   *** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
   revision 891a217572193e9f199d523f4cd8b4e357aa2a16
   Author: Meenakshi TK [2]<meenak...@hasolutions.in>
   Date: Tue, 11 Sep 2018 14:55:22 +0530
   plma: add and modify traces [#199]
   revision c83896b2219c17b06b6549d1bbc100e8eac69e63
   Author: Meenakshi TK [3]<meenak...@hasolutions.in>
   Date: Tue, 11 Sep 2018 12:47:53 +0530
   plma: align the function headers [#199]
   Complete diffstat:
   ------------------
   src/plm/agent/plma_api.c | 1874
   +++++++--------------------------------------
   src/plm/agent/plma_comm.c | 68 +-
   src/plm/agent/plma_init.c | 301 ++------
   src/plm/agent/plma_mds.c | 174 +----
   4 files changed, 371 insertions(+), 2046 deletions(-)
   Testing Commands:
   -----------------
   Compiled
   Testing, Expected Results:
   --------------------------
   Compiled
   Conditions of Submission:
   -------------------------
   Ack from maintainers
   Arch Built Started Linux distro
   -------------------------------------------
   mips n n
   mips64 n n
   x86 n n
   x86_64 y y
   powerpc n n
   powerpc64 n n
   Reviewer Checklist:
   -------------------
   [Submitters: make sure that your review doesn't trigger any
   checkmarks!]
   Your checkin has not passed review because (see checked entries):
   ___ Your RR template is generally incomplete; it has too many blank
   entries
   that need proper data filled in.
   ___ You have failed to nominate the proper persons for review and push.
   ___ Your patches do not have proper short+long header
   ___ You have grammar/spelling in your header that is unacceptable.
   ___ You have exceeded a sensible line length in your
   headers/comments/text.
   ___ You have failed to put in a proper Trac Ticket # into your commits.
   ___ You have incorrectly put/left internal data in your comments/files
   (i.e. internal bug tracking tool IDs, product names etc)
   ___ You have not given any evidence of testing beyond basic build
   tests.
   Demonstrate some level of runtime or other sanity testing.
   ___ You have ^M present in some of your files. These have to be
   removed.
   ___ You have needlessly changed whitespace or added whitespace crimes
   like trailing spaces, or spaces before tabs.
   ___ You have mixed real technical changes with whitespace and other
   cosmetic code cleanup changes. These have to be separate commits.
   ___ You need to refactor your submission into logical chunks; there is
   too much content into a single commit.
   ___ You have extraneous garbage in your review (merge commits etc)
   ___ You have giant attachments which should never have been sent;
   Instead you should place your content in a public tree to be pulled.
   ___ You have too many commits attached to an e-mail; resend as threaded
   commits, or place in a public tree for a pull.
   ___ You have resent this content multiple times without a clear
   indication
   of what has changed between each re-send.
   ___ You have failed to adequately and individually address all of the
   comments and change requests that were proposed in the initial review.
   ___ You have a misconfigured ~/.gitconfig file (i.e. user.name,
   user.email etc)
   ___ Your computer have a badly configured date and time; confusing the
   the threaded patch review.
   ___ Your changes affect IPC mechanism, and you don't present any
   results
   for in-service upgradability test.
   ___ Your changes affect user manual and documentation, your patch
   series
   do not contain the patch that updates the Doxygen manual.

References

   1. https://protect-us.mimecast.com/s/WHyvCR6Lz6C4O9WtNDUON
   2. mailto:meenak...@hasolutions.in
   3. mailto:meenak...@hasolutions.in

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to