Hi Ratnamala,
Ack with minor comments below.
Regards, Vu
> -----Original Message-----
> From: Ratnamala Tallari <ratnam...@hasolutions.in>
> Sent: Saturday, September 1, 2018 8:02 PM
> To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net; Ratnamala Tallari
> <ratnam...@hasolutions.in>
> Subject: [PATCH 2/2] log: add new test case of API saLogInitialize() of
apitest
> [#2915]
>
> ---
> src/log/apitest/tet_saLogInitialize.c | 75
> +++++++++++++++++++++++++++++++++++
> 1 file changed, 75 insertions(+)
>
> diff --git a/src/log/apitest/tet_saLogInitialize.c
> b/src/log/apitest/tet_saLogInitialize.c
> index 82d176e..ccab172 100644
> --- a/src/log/apitest/tet_saLogInitialize.c
> +++ b/src/log/apitest/tet_saLogInitialize.c
> @@ -116,6 +116,64 @@ void
> saLogInitialize_version_NULL_pointer_error(void)
> test_validate(rc, SA_AIS_ERR_INVALID_PARAM);
> }
>
> +void saLogInitialize_handle_version_NULL_pointer_error_13(void)
> +{
> + rc = saLogInitialize(NULL, &logCallbacks, NULL);
> + logFinalize();
> + test_validate(rc, SA_AIS_ERR_INVALID_PARAM);
> +}
> +
> +void saLogInitialize_handle_callbk_NULL_pointer_error_14(void)
> +{
> + SaVersionT log_version = {'A', 2};
> + rc = saLogInitialize(NULL, NULL, &log_version);
> + logFinalize();
> + test_validate(rc, SA_AIS_ERR_INVALID_PARAM);
> +}
> +
> +void saLogInitialize_handle_callbk_version_NULL_pointer_error_15(void)
> +{
> + rc = saLogInitialize(NULL, NULL, NULL);
> + logFinalize();
> + test_validate(rc, SA_AIS_ERR_INVALID_PARAM);
> +}
> +
> +void saLogInitialize_invalid_values_error_16(void)
> +{
> + rc = saLogInitialize(0, 0, 0);
> + logFinalize();
> + test_validate(rc, SA_AIS_ERR_INVALID_PARAM);
> +}
[Vu] Is duplicated from the test case `
saLogInitialize_handle_callbk_version_NULL_pointer_error_15` above?
> +void saLogInitialize_invalid_handle_callbk__NULL_pointer_error_17(void)
> +{
> + SaVersionT log_version = {'A', 2};
> + rc = saLogInitialize(0, NULL, &log_version);
> + logFinalize();
> + test_validate(rc, SA_AIS_ERR_INVALID_PARAM);
> +}
[Vu] Is duplicated from `
saLogInitialize_handle_callbk_NULL_pointer_error_14` ?
> +
> +void saLogInitialize_invalid_handle_version_NULL_pointer_error_18(void)
> +{
> + rc = saLogInitialize(0, &logCallbacks, NULL);
> + logFinalize();
> + test_validate(rc, SA_AIS_ERR_INVALID_PARAM);
> +}
[Vu] Is duplicated from `
saLogInitialize_handle_version_NULL_pointer_error_13` ?
> +
> +void saLogInitialize_invalid_handle_invalid_callbk_error_19(void)
> +{
> + SaVersionT log_version = {'A', 2};
> + rc = saLogInitialize(0, 0, &log_version);
> + logFinalize();
> + test_validate(rc, SA_AIS_ERR_INVALID_PARAM);
> +}
[Vu] Is duplicated from `
saLogInitialize_handle_callbk_NULL_pointer_error_14`?
> +
> +void saLogInitialize_invalid_handle_invalid_version_error_20(void)
> +{
> + rc = saLogInitialize(0, &logCallbacks, 0);
> + logFinalize();
> + test_validate(rc, SA_AIS_ERR_INVALID_PARAM);
> +}
[Vu] Is duplicated from `
saLogInitialize_handle_version_NULL_pointer_error_13` + `
saLogInitialize_invalid_handle_version_NULL_pointer_error_18`
> +
> extern void saLogSelectionObjectGet_01(void);
> extern void saLogSelectionObjectGet_02(void);
> extern void saLogFinalize_01(void);
> @@ -149,6 +207,23 @@ __attribute__((constructor)) static void
> saLibraryLifeCycle_constructor(void)
> "saLogInitialize() with minor version is not set");
> test_case_add(1, saLogInitialize_version_NULL_pointer_error,
> "saLogInitialize() valid handle, valid callbacks and version
as
> NULL");
> + test_case_add(1,
> saLogInitialize_handle_version_NULL_pointer_error_13,
> + "saLogInitialize() with handle as null, version as null");
> + test_case_add(1,
> saLogInitialize_handle_callbk_NULL_pointer_error_14,
> + "saLogInitialize() with handle as null and callbk as null");
> + test_case_add(1,
> saLogInitialize_handle_callbk_version_NULL_pointer_error_15,
> + "saLogInitialize() with all null values");
> + test_case_add(1, saLogInitialize_invalid_values_error_16,
> + "saLogInitialize() with all invalid values");
> + test_case_add(1,
> saLogInitialize_invalid_handle_callbk__NULL_pointer_error_17,
> + "saLogInitialize() with invalid handle and null
calback");
> + test_case_add(1,
> saLogInitialize_invalid_handle_version_NULL_pointer_error_18,
> + "saLogInitialize() with invalid handle and version as
null");
> + test_case_add(1,
> saLogInitialize_invalid_handle_invalid_callbk_error_19,
> + "saLogInitialize() with invalid handle, invalid callbk");
> + test_case_add(1,
> saLogInitialize_invalid_handle_invalid_version_error_20,
> + "saLogInitialize() with invalid handle, invalid version");
> +
> test_case_add(1, saLogSelectionObjectGet_01,
> "saLogSelectionObjectGet() OK");
> test_case_add(1, saLogSelectionObjectGet_02,
> --
> 2.7.4
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
