Summary: fmd: enable reload of configuration without restart [#2923]
Review request for Ticket(s): 2923
Peer Reviewer(s): Hans
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2923
Base revision: 6f4f5ddc776a7e566b6958ecd4d4a3502bccfa5e
Personal repository: git://git.code.sf.net/u/userid-2226215/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries y
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
revision a297b2e05fd428f2088c4d1c345ae6052fdf51f1
Author: Gary Lee <gary....@dektech.com.au>
Date: Wed, 19 Sep 2018 03:33:52 +0000
fmd: enable reload of configuration without restart [#2923]
Only FMS_PROMOTE_ACTIVE_TIMER, FMS_NODE_ISOLATION_TIMEOUT and
FMS_ACTIVATION_SUPERVISION_TIMER are currently supported.
These values can be changed in fmd.conf and take effect
by sending SIGHUP to fmd.
revision 9ffeed8b4de9d726d20a043af6f6ddee1e7ee666
Author: Gary Lee <gary....@dektech.com.au>
Date: Wed, 19 Sep 2018 03:33:52 +0000
base: add config file reader [#2923]
Some configuration attribute are read by OpenSAF daemons as
environment variables. eg.
export FMS_PROMOTE_ACTIVE_TIMER=0
There is no easy way to reload these values without a restart.
ConfigFileReader will parse these files looking for 'export VAR=VAL'
and store them into a map, so a daemon can reload configuration
without a restart.
revision 87fd1e1ad98d8622683d0bc0512964d84c906c20
Author: Gary Lee <gary....@dektech.com.au>
Date: Wed, 19 Sep 2018 03:33:52 +0000
base: remove use of SIGHUP to toggle INFO messages [#2923]
We need to use SIGHUP for reload of configuration
Added Files:
------------
src/base/config_file_reader.cc
src/base/config_file_reader.h
Complete diffstat:
------------------
src/base/Makefile.am | 2 ++
src/base/config_file_reader.cc | 43 ++++++++++++++++++++++++++
src/base/config_file_reader.h | 30 ++++++++++++++++++
src/base/daemon.c | 5 +--
src/base/logtrace.cc | 22 -------------
src/fm/fmd/fm_cb.h | 2 ++
src/fm/fmd/fm_main.cc | 70 ++++++++++++++++++++++++++++++++++++++++--
src/fm/fmd/osaf-fmd.in | 1 +
8 files changed, 149 insertions(+), 26 deletions(-)
Testing Commands:
-----------------
1) Send SIGHUP to amfnd
2) Send SIGHUP to fmd
Testing, Expected Results:
--------------------------
1) no action
2) "reload configuration" is seen in syslog
If tracing is enabled:
<141>1 2018-09-19T13:31:06.040259+10:00 SC-1 osaffmd 187 osaffmd [meta
sequenceId="1"] 187:fm/fmd/fm_main.cc:388 NO reload configuration
<143>1 2018-09-19T13:31:06.063054+10:00 SC-1 osaffmd 187 osaffmd [meta
sequenceId="2"] 187:fm/fmd/fm_main.cc:403 TR NODE_ISOLATION_TIMEOUT =
0.000000000
<143>1 2018-09-19T13:31:06.063067+10:00 SC-1 osaffmd 187 osaffmd [meta
sequenceId="3"] 187:fm/fmd/fm_main.cc:397 TR FMS_PROMOTE_ACTIVE_TIMER = 5000
Conditions of Submission:
-------------------------
*** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC ***
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
