Summary: clm: add new test case of API saClmClusterNotificationFree_4() of apitest [#2914] Review request for Ticket(s): 2914-1 Peer Reviewer(s):Anders, Hans, Ravi Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2914-1 Base revision: f8a6848a1cdbff0b518c3db951e4689e260226c7 Personal repository: git://git.code.sf.net/u/mohan-hasoln/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests y Other n Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 9a6bf69135567cdceded5cd89b0a22138b7c116a Author: Mohan Kanakam <[email protected]> Date: Tue, 6 Nov 2018 15:41:15 +0530 clm: add new test case in saClmResponse_4() of apitest [#2914] revision afd96329f2b2cd6211e0dae90a6e46881d140092 Author: Mohan Kanakam <[email protected]> Date: Tue, 6 Nov 2018 15:15:32 +0530 clm: add new test case saClmClusterNodeGetAsync() of apitest [#2914] revision 71b52f9c79477fe8ee567123b68ebf52cd6ee433 Author: Mohan Kanakam <[email protected]> Date: Tue, 6 Nov 2018 15:05:34 +0530 clm: add new test case of API saClmClusterNodeGet_4() of apitest [#2914] revision eda88ade8b2d87ba657465ef17d73cb553082551 Author: Mohan Kanakam <[email protected]> Date: Tue, 6 Nov 2018 14:39:02 +0530 clm: add new test case of API saClmClusterNotificationFree_4() of apitest [#2914] Complete diffstat: ------------------ src/clm/apitest/tet_saClmClusterNodeGet.cc | 21 +++++++++++++++++++++ src/clm/apitest/tet_saClmClusterNodeGetAsync.cc | 19 +++++++++++++++++++ src/clm/apitest/tet_saClmClusterNotificationFree.cc | 14 ++++++++++++++ src/clm/apitest/tet_saClmResponse.cc | 9 +++++++++ 4 files changed, 63 insertions(+) Testing Commands: ----------------- ./clmtest Testing, Expected Results: -------------------------- 5 PASSED saClmClusterNotificationFree with finalized handle 10 PASSED/PASSED saClmClusterNodeGet & saClmClusterNodeGet_4 with Finalized handle 10 PASSED/PASSED saClmClusterNodeGetAsync with finalized handle 6 PASSED saClmResponse with Finalized handle Conditions of Submission: ------------------------- Ack from mainatiners Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
