Hi Hans/Vu/Gary/Alex, Polite remainder for review. Thanks Mohan High Availability Solutions Pvt. Ltd. www.hasolutions.in
--------- Original Message --------- Subject: RE: [PATCH 0/3] Review Request for ckpt: add new test cases in apitest [#2939] From: mo...@hasolutions.in Date: 10/18/18 1:37 pm To: hans.nordeb...@ericsson.com, vu.m.ngu...@dektech.com.au, gary....@dektech.com.au, ajo...@rbbn.com Cc: opensaf-devel@lists.sourceforge.net, "Mohan Kanakam" <mo...@hasolutions.in> Hi Hans/Vu/Gary/Alex, Polite remainder for review. Thanks Mohan High Availability Solutions Pvt. Ltd. www.hasolutions.in --------- Original Message --------- Subject: [PATCH 0/3] Review Request for ckpt: add new test cases in apitest [#2939] From: "Mohan Kanakam" <mo...@hasolutions.in> Date: 10/11/18 3:03 pm To: hans.nordeb...@ericsson.com, vu.m.ngu...@dektech.com.au, gary....@dektech.com.au, ajo...@rbbn.com Cc: opensaf-devel@lists.sourceforge.net, "Mohan Kanakam" <mo...@hasolutions.in> Summary: ckpt: add new test case of API saCkptSelectionObjectGet() of apitest [#2939] Review request for Ticket(s): 2939 Peer Reviewer(s):Hans Nordeback, Vu Minh Nguyen, Gary Lee, Alex Jones Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2939 Base revision: cad806745a2eb96024ff18081ccf6d208b0fb93b Personal repository: git://git.code.sf.net/u/mohan-hasoln/review -------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests y Other n NOTE: Patch(es) contain lines longer than 80 characers Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision f7e48ce52273d2a2af4bc0eb9b4d5d34d65af072 Author: Mohan Kanakam <mo...@hasolutions.in> Date: Thu, 11 Oct 2018 14:54:32 +0530 ckpt: add new test case of API saCkptFinalize() of apitest [#2939] revision 0aba5a03faf789fa339de3f103b0df2b1a911d2c Author: Mohan Kanakam <mo...@hasolutions.in> Date: Thu, 11 Oct 2018 13:27:58 +0530 ckpt: add new test case of API saCkptDispatch() of apitest [#2939] revision 3e9b412d3f121e00f4d30841e7065ab5a94cd675 Author: Mohan Kanakam <mo...@hasolutions.in> Date: Thu, 11 Oct 2018 12:23:14 +0530 ckpt: add new test case of API saCkptSelectionObjectGet() of apitest [#2939] Complete diffstat: ------------------ src/ckpt/apitest/test_cpa.c | 234 +++++++++++++++++++++++++++++++++++++++ src/ckpt/apitest/test_cpa_util.c | 28 ++++- src/ckpt/apitest/test_cpsv.h | 9 ++ 3 files changed, 270 insertions(+), 1 deletion(-) Testing Commands: ----------------- ./ckpttest Testing, Expected Results: -------------------------- All tests were passed Conditions of Submission: ------------------------- Ack from maintainers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
