Summary: lck: add new test case of API saLckInitialize() of apitest [#2966]
Review request for Ticket(s): 2966
Peer Reviewer(s):Alex
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2966
Base revision: c43ae9d97d169cc4a3b57da14ed9191dca8dfba5
Personal repository: git://git.code.sf.net/u/mohan-hasoln/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests y
Other n
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 89d82aec7e6d3c2007eddcb52e63ffba5e6c3584
Author: Mohan Kanakam <mo...@hasolutions.in>
Date: Mon, 19 Nov 2018 16:15:00 +0530
lck: add new test case of API saLckFinalize() of apitest [#2966]
revision 8d73d185187f1f9dec2faa9f71b2cb3fd2469231
Author: Mohan Kanakam <mo...@hasolutions.in>
Date: Mon, 19 Nov 2018 16:13:40 +0530
lck: add new test case of API saLckDispatch() of apitest [#2966]
revision 382533939a003741f5bfeb2cc211fb4f1480b84a
Author: Mohan Kanakam <mo...@hasolutions.in>
Date: Mon, 19 Nov 2018 13:28:45 +0530
lck: add new test case of API saLckSelectionObjectGet() of apitest [#2966]
revision c900f32a7410f9ca5c05eaf7741cf7a1bace79eb
Author: Mohan Kanakam <mo...@hasolutions.in>
Date: Mon, 19 Nov 2018 13:26:45 +0530
lck: add new test case of API saLckInitialize() of apitest [#2966]
Complete diffstat:
------------------
src/lck/apitest/tet_gla.c | 50 +++++++++++++++++++++++++++++++++++++++++
src/lck/apitest/tet_gla_conf.c | 6 +++++
src/lck/apitest/tet_glsv.h | 6 +++++
src/lck/apitest/tet_glsv_util.c | 20 ++++++++++++++++-
4 files changed, 81 insertions(+), 1 deletion(-)
Testing Commands:
-----------------
./lcktest
Testing, Expected Results:
--------------------------
11 PASSED saLckInitialize with Null lock handle,callbacks and version
6 PASSED 6 PASSED saLckSelectionObjectGet with NULL lock handle
10 PASSED saLckDispatch with invalid lock handle and invalid dispatch flags
7 PASSED 7 PASSED saLckFinalize with NULL callbacks lock handle
Conditions of Submission:
-------------------------
Ack from maintainers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
