Hi,
I have reviewed this and have some comments and a question.
For comments see attached .diff file. Please apply it on the ticket-2915 branch
to see my comments in the correct context. Comments are tagged [Lennart].
My question:
Does the log service pass all the new test cases?
Please make one commit containing all the new test cases instead of 7 commits.
When this is fixed you can send a new review request and I will do some testing.
Thanks
Lennart
-----Original Message-----
From: Mohan Kanakam <mo...@hasolutions.in>
Sent: den 16 november 2018 09:47
To: Lennart Lund <lennart.l...@ericsson.com>; Vu Minh Nguyen
<vu.m.ngu...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net; Mohan Kanakam <mo...@hasolutions.in>
Subject: [PATCH 0/7] Review Request for log: add new test cases in apitest
[#2915]
Summary: log: add new test case of API saLogInitialize() of apitest v2 [#2915]
Review request for Ticket(s): 2915 Peer Reviewer(s):lennart, vu Pull request
to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop
Development branch: ticket-2915 Base revision:
f8a6848a1cdbff0b518c3db951e4689e260226c7
Personal repository: git://git.code.sf.net/u/mohan-hasoln/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests y
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 7501d8990519c8db94269f1af789e3185c7e7a7e
Author: Mohan Kanakam <mo...@hasolutions.in>
Date: Fri, 16 Nov 2018 13:53:15 +0530
log: add new test case of saLogStreamClose() of apitest v2 [#2915]
revision 75c71356cb5727956235a2e3cdf8da37a722bbd1
Author: Mohan Kanakam <mo...@hasolutions.in>
Date: Fri, 16 Nov 2018 13:49:55 +0530
log: add new test case of saLogWriteLogAsync() of apitest v2 [#2915]
revision aad0abf08c946a57e9ff25f56608e17a876f4f63
Author: Mohan Kanakam <mo...@hasolutions.in>
Date: Fri, 16 Nov 2018 13:48:39 +0530
log: add new test case of saLogStreamOpen_2() of apitest v2 [#2915]
revision 0032535d6296088c88343676f0a4f8af2f664ed8
Author: Mohan Kanakam <mo...@hasolutions.in>
Date: Fri, 16 Nov 2018 13:47:18 +0530
log: add new test case of API saLogFinalize() of apitest v2 [#2915]
revision be72e94f36df6a429fbb426dc1c2e7fe8219df12
Author: Mohan Kanakam <mo...@hasolutions.in>
Date: Fri, 16 Nov 2018 13:45:50 +0530
log: add new test case of API saLogDispatch() of apitest v2 [#2915]
revision 8cc54da8a85617d1fe7a1c85e9e5f30444f0fa6b
Author: Mohan Kanakam <mo...@hasolutions.in>
Date: Fri, 16 Nov 2018 13:44:06 +0530
log: add new test case of saLogSelectionObjectGet() of apitest v2 [#2915]
revision 0ec511ad16ad9214696de1021518d5d9ace1d9f1
Author: Mohan Kanakam <mo...@hasolutions.in>
Date: Fri, 16 Nov 2018 12:20:04 +0530
log: add new test case of API saLogInitialize() of apitest v2 [#2915]
Complete diffstat:
------------------
src/log/apitest/tet_saLogDispatch.c | 28 ++++++++++
src/log/apitest/tet_saLogFinalize.c | 16 ++++++
src/log/apitest/tet_saLogInitialize.c | 77 +++++++++++++++++++++++++++
src/log/apitest/tet_saLogSelectionObjectGet.c | 16 ++++++
src/log/apitest/tet_saLogStreamClose.c | 28 ++++++++++
src/log/apitest/tet_saLogStreamOpen_2.c | 24 +++++++++
src/log/apitest/tet_saLogWriteLogAsync.c | 34 ++++++++++++
7 files changed, 223 insertions(+)
Testing Commands:
-----------------
./logtest
Testing, Expected Results:
--------------------------
12 PASSED saLogInitialize() with version as NULL
13 PASSED saLogInitialize() with handle as null, version as null
14 PASSED saLogInitialize() with handle as null and callbk as null
15 PASSED saLogInitialize() with handle, cbk and version as null values
18 PASSED saLogSelectionObjectGet() with finalized log handle
20 PASSED saLogDispatch() with finalized handle SA_AIS_ERR_BAD_HANDLE
21 PASSED saLogDispatch() with invalid handle SA_AIS_ERR_BAD_HANDLE
24 PASSED saLogFinalize() with finalized log handle
22 PASSED saLogStreamOpen with invalid handle,logStreamName to NULL
pointer,logFileCreateAttributes to NULL pointer and logStreamOpenFlags to
ZERO(0)
41 PASSED saLogWriteLogAsync() after LogFianlize
45 PASSED saLogStreamClose BAD_HANDLE
Conditions of Submission:
-------------------------
Ack from manintainers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
