Hi, I will revert back by 18th. Thanks, Mathi.
On Tue, Dec 11, 2018 at 7:04 AM <mo...@hasolutions.in> wrote: > Hi Mathi, hans, > Polite remainder for review. > > > Thanks > Mohan > High Availability Solutions Pvt. Ltd. > www.hasolutions.in > > > > --------- Original Message --------- > Subject: [PATCH 0/1] Review Request for evt: resurrect apitests [#2974] > From: "Mohan Kanakam" <mo...@hasolutions.in> > Date: 11/26/18 1:55 pm > To: mathi.np....@gmail.com, hans.nordeb...@ericsson.com > Cc: opensaf-devel@lists.sourceforge.net, "Mohan Kanakam" < > mo...@hasolutions.in> > > Summary: evt: resurrect apitests [#2974] > Review request for Ticket(s): 2974 > Peer Reviewer(s): mathi, hans > Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** > Affected branch(es): develop > Development branch: ticket-2974 > Base revision: 72ff674dea7f796b8d957ed7ecaccb0d404f6360 > Personal repository: git://git.code.sf.net/u/mohan-hasoln/review > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services n > OpenSAF services n > Core libraries n > Samples n > Tests y > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > Resurrect apitests > > revision 55a0f051418350a5392f328fd35cf1237add96c8 > Author: Mohan Kanakam <mo...@hasolutions.in> > Date: Mon, 26 Nov 2018 13:11:49 +0530 > > evt: resurrect apitests [#2974] > > > > Added Files: > ------------ > src/evt/apitest/evttest.c > src/evt/apitest/Makefile > > > Complete diffstat: > ------------------ > opensaf.spec.in | 1 + > src/evt/Makefile.am | 17 ++ > src/evt/apitest/Makefile | 20 +++ > src/evt/apitest/evttest.c | 44 +++++ > src/evt/apitest/tet_eda.c | 335 +++++++++++++++++++++++------------- > src/evt/apitest/tet_eda.h | 22 ++- > src/evt/apitest/tet_edsv_func.c | 54 ++---- > src/evt/apitest/tet_edsv_util.c | 201 +++++++++++++++++++++- > src/evt/apitest/tet_edsv_wrappers.c | 62 ++++++- > 9 files changed, 579 insertions(+), 177 deletions(-) > > > Testing Commands: > ----------------- > ./evttest > > Testing, Expected Results: > -------------------------- > All tests were passed. > > Conditions of Submission: > ------------------------- > Ack from maintainers > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 y y > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, > user.email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > > _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
