Summary: imm: allow empty-value attribute with default-tag persisted [#2985]
Review request for Ticket(s): 2985
Peer Reviewer(s): Lennart, Hans, Gary
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2985
Base revision: 5f7408cc86bbbd7cbaa6f94f9ed83fe70c713a16
Personal repository: git://git.code.sf.net/u/winhvu/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 67b1566d66cbeb2a066ae283a406a122f7168ae5
Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>
Date: Tue, 15 Jan 2019 10:29:26 +0700
imm: allow empty-value attribute with default-tag persisted [#2985]
During runtime, when replacing value of an attribute which has default-value
tag with NULL, this NULL value is not persistent after cluster is rebooted -
NULL value will be automatically replaced with its default value by IMM.
This behavior causes several unexpected results. Below is an use case:
User defines an attribute with name `maxAge`; the value shows how many days
user passwords will get expired; default value is 30 days. If replacing with
a NULL/empty, it means the passwords will never get expired.
User may change the existing value with NULL - expect the passwords never get
expired, but later on, after cluster is rebooted, that value is silently
replaced with the default value without notice of user.
This patch makes some changes in immdump/immloader/imm om library/immnd
to make NULL value in such case persisted even after cluster is rebooted.
Complete diffstat:
------------------
src/imm/README | 10 +---
src/imm/agent/imma_om_api.cc | 7 ++-
src/imm/immloadd/imm_loader.cc | 23 ++++++----
src/imm/immloadd/imm_pbe_load.cc | 16 ++++---
src/imm/immnd/ImmModel.cc | 9 +++-
src/imm/tools/imm_dumper.cc | 15 +++++-
src/imm/tools/imm_xmlw_dump.cc | 98 +++++++++++++++++++++++++++-------------
7 files changed, 119 insertions(+), 59 deletions(-)
Testing Commands:
-----------------
1) Import TestClass.xml
immcfg -f TestClass.xml
2) Create an object of TestClass
immcfg -c TestClass testClass=0
3) Replace all attribute values of that object with empty
4) Dump whole IMM database (using with new option -n), and overwrite existing
imm.xml file
5) Restart cluster with new dump
6) Check the values of attributes that have been replaced with empty
6) Repeat the test with PBE enable.
Testing, Expected Results:
--------------------------
The attributes remain empty
Conditions of Submission:
-------------------------
Ack(s) from peer reviewer(s)
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
