ack, review only/Thanks HansN
-----Original Message-----
From: Gary Lee <gary....@dektech.com.au>
Sent: den 26 mars 2019 02:05
To: Minh Hon Chau <minh.c...@dektech.com.au>; Hans Nordebäck
<hans.nordeb...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.net; Gary Lee <gary....@dektech.com.au>
Subject: [PATCH 1/1] osaf: ensure an error is returned if takeover_request
fails [#3023]
if we cannot read the result of a takeover_request, ensure we return an error
---
src/osaf/consensus/consensus.cc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/osaf/consensus/consensus.cc b/src/osaf/consensus/consensus.cc
index cf307b3..480f7d2 100644
--- a/src/osaf/consensus/consensus.cc
+++ b/src/osaf/consensus/consensus.cc
@@ -433,6 +433,8 @@ SaAisErrorT Consensus::CreateTakeoverRequest(const
std::string& current_owner,
return rc;
}
+ // in case takeover request cannot be read rc =
+ SA_AIS_ERR_FAILED_OPERATION;
// wait up to max_takeover_retry seconds for request to be answered
retries = 0;
while (retries < max_takeover_retry_) {
--
2.7.4
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
