Summary: mds: use new TIPC getsockopt to log receive queue utilization [#3038] Review request for Ticket(s): 3038 Peer Reviewer(s): AndersW, Lennart, Gary Pull request to: Affected branch(es): develop Development branch: ticket-3038 Base revision: 3b124020051730287ace8bd9ab28a8fa431fc85a Personal repository: git://git.code.sf.net/u/hansnordeback/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries y Samples n Tests n Other n NOTE: Patch(es) contain lines longer than 80 characers Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 7d1b566f8167f9fbe1512a78f0bcf4fb1c58f449 Author: Hans Nordeback <[email protected]> Date: Mon, 20 May 2019 13:47:28 +0200 mds: use new TIPC getsockopt to log receive queue utilization [#3038] Added Files: ------------ src/base/statistics.h src/mds/mds_tipc_recvq_stats.cc src/mds/mds_tipc_recvq_stats.h src/mds/mds_tipc_recvq_stats_impl.cc src/mds/mds_tipc_recvq_stats_impl.h Complete diffstat: ------------------ 00-README.conf | 14 +++ src/base/Makefile.am | 1 + src/base/statistics.h | 88 +++++++++++++++++ src/mds/Makefile.am | 8 +- src/mds/mds_dt_tipc.c | 3 + src/mds/mds_tipc_recvq_stats.cc | 29 ++++++ src/mds/mds_tipc_recvq_stats.h | 32 +++++++ src/mds/mds_tipc_recvq_stats_impl.cc | 178 +++++++++++++++++++++++++++++++++++ src/mds/mds_tipc_recvq_stats_impl.h | 39 ++++++++ 9 files changed, 390 insertions(+), 2 deletions(-) Testing Commands: ----------------- Pls. see 00-README.conf Testing, Expected Results: -------------------------- Pls. see 00-README.conf Conditions of Submission: ------------------------- *** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC *** Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
