Summary: log: Delete the older file without closing current log file via admin
operation [#3046]
Review request for Ticket(s): 3046
Peer Reviewer(s): Lennart, Vu
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-3046
Base revision: 0661e3a9c17ea1c1ac13550d195b651453423e2f
Personal repository: git://git.code.sf.net/u/canht32/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision de4381569c8155b30c095305a77c4360dd772557
Author: Canh Van Truong <canh.v.tru...@dektech.com.au>
Date: Thu, 13 Jun 2019 18:31:52 +0700
log: Delete the older file without closing current log file via admin operation
[#3046]
Improve the enhancement of ticket #3022, the user can rotate (delete) older log
files without closing current log file.
LOG add new parameter (numberOfFilesToRemove) to admin op command with id = 2.
- If parameter exists, LOGD remove number of older file base on parameter value
- If parameter is omitted, LOGD rotates log file normally. (closing current log
file, rotate log file if needed, create new log file)
This helps to avoid creating empty log file or small log file size
Complete diffstat:
------------------
src/log/apitest/tet_LogOiOps.c | 272 +++++++++++++++++++++++++++++------------
src/log/logd/lgs_filehdl.cc | 4 +-
src/log/logd/lgs_imm.cc | 66 +++++++---
src/log/logd/lgs_stream.cc | 31 +++--
src/log/logd/lgs_stream.h | 3 +-
5 files changed, 265 insertions(+), 111 deletions(-)
Testing Commands:
-----------------
*** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES ***
logtest 6 47, 49 , 50
Testing, Expected Results:
--------------------------
*** PASTE COMMAND OUTPUTS / TEST RESULTS ***
All test cases passed
Conditions of Submission:
-------------------------
*** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC ***
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
