Summary: amfd: include failover info in coldsync [#3060]
Review request for Ticket(s): 3060
Peer Reviewer(s): Minh, Hans, Thang, Thuan 
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-3060
Base revision: ec296cbb38761831929a97a8d94d177130f656c9
Personal repository: git://git.code.sf.net/u/userid-2226215/review

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            y 
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   n


Comments (indicate scope for each "y" above):
---------------------------------------------

revision 9443abefdeaae481dbe483b708db8d467619b8c1
Author: Gary Lee <gary....@dektech.com.au>
Date:   Fri, 19 Jul 2019 16:02:19 +1000

amfd: include failover info in coldsync [#3060]

Failover information is not currently included in coldsync. This means
if a delayed failover is in progress *before* a standby controller is
available, *and* a controller failover occurs, then information about
the delayed failover is lost.



Complete diffstat:
------------------
 src/amf/amfd/chkop.cc              |  4 ++
 src/amf/amfd/ckpt.h                |  4 +-
 src/amf/amfd/ckpt_dec.cc           | 77 ++++++++++++++++++++++++++++----------
 src/amf/amfd/ckpt_edu.cc           |  2 +
 src/amf/amfd/ckpt_enc.cc           |  5 ++-
 src/amf/amfd/node.h                |  3 ++
 src/amf/amfd/node_state_machine.cc |  2 +
 src/amf/amfd/util.cc               |  1 +
 8 files changed, 76 insertions(+), 22 deletions(-)


Testing Commands:
-----------------
1. Enable delayed node failover and network fence a PL while
there is no standby SC. Before the failover occurs,
power up the standby SC, and force a controller failover.

2. Ensure different versions of amfd can cold sync with each
other.

Testing, Expected Results:
--------------------------
1. The standby SC (now active) should continue the node failover.

2. It works.

Conditions of Submission:
-------------------------
ack from any reviewer

Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      y          y  
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.



_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to