Summary: msg: handle CLM-API errors in SC-absence [#2299]
Review request for Ticket(s): 2299
Peer Reviewer(s): Anders
Pull request to:
Affected branch(es): develop
Development branch: ticket-2299
Base revision: 88ba98b8e45621508b528010e524b89068a05d8e
Personal repository: git://git.code.sf.net/u/trguitar/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
revision 847e1824342a2feef2c84ca13d2a2679f95b82df
Author:Alex Jones <ajo...@rbbn.com>
Date:Fri, 6 Sep 2019 09:33:11 -0400
msg: handle CLM-API errors in SC-absence [#2299]
Feb 10 14:44:19 PL-3 osafmsgnd[3749]: ER saClmDispatch Failed with error 9
msgd and msgnd are not handling SA_AIS_ERR_BAD_HANDLE during SC absence.
They need to reinit with CLM in this case.
Complete diffstat:
------------------
src/msg/msgd/mqd_api.c | 59 +++++++++++++++--
src/msg/msgnd/mqnd_db.h | 1 +
src/msg/msgnd/mqnd_init.c | 164 +++++++++++++++++++++++++++++++++-------------
3 files changed, 173 insertions(+), 51 deletions(-)
Testing Commands:
-----------------
1) bring up 4 SCs with SC absence enabled
2) kill the active and standby SCs
Testing, Expected Results:
--------------------------
1) msgd and msgnd on the new active and standby should not be cpu bound
2) msgd and msgnd should successfully reinit with CLM
Conditions of Submission:
-------------------------
Ack from developer, or Sep 12
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
-----------------------------------------------------------------------------------------------------------------------
Notice: This e-mail together with any attachments may contain information of
Ribbon Communications Inc. that
is confidential and/or proprietary for the sole use of the intended recipient.
Any review, disclosure, reliance or
distribution by others or forwarding without express permission is strictly
prohibited. If you are not the intended
recipient, please notify the sender immediately and then delete all copies,
including any attachments.
-----------------------------------------------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
