Summary: amfd: fix key tuple for sirankedsu db [#3076]
Review request for Ticket(s): 3076
Peer Reviewer(s): Hans, Gary, Quyen
Pull request to:
Affected branch(es): develop
Development branch: ticket-3076
Base revision: 98ab94adf2610a36908c815de8831b5cdd9335a4
Personal repository: git://git.code.sf.net/u/trguitar/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
revision 9b819dbd8e3ee709b800e5889e3a915521a1607b
Author:Alex Jones <ajo...@rbbn.com>
Date:Thu, 12 Sep 2019 13:26:40 -0400
amfd: fix key tuple for sirankedsu db [#3076]
Higher ranked SUs are not always picked.
The tuple key has su name first, then si name, then rank. This is wrong.
Su name should be last, as we want to sort by si name and rank before
sorting by su name.
Make su name last in the tuple key.
Complete diffstat:
------------------
src/amf/amfd/sirankedsu.cc | 21 ++++++++++-----------
src/amf/amfd/susi.h | 2 +-
2 files changed, 11 insertions(+), 12 deletions(-)
Testing Commands:
-----------------
1) create n-way active sg with multiple sus
2) create SaAmfSIRankedSU objects for each su such that
the rank is numerically lowest for the highest su in
alphabetical order.
3) lock the si
4) unlock all the SUs
5) unlock the si
Testing, Expected Results:
--------------------------
Si should be assigned active to the lowest numerical rank.
Conditions of Submission:
-------------------------
Ack from Quyen.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
-----------------------------------------------------------------------------------------------------------------------
Notice: This e-mail together with any attachments may contain information of
Ribbon Communications Inc. that
is confidential and/or proprietary for the sole use of the intended recipient.
Any review, disclosure, reliance or
distribution by others or forwarding without express permission is strictly
prohibited. If you are not the intended
recipient, please notify the sender immediately and then delete all copies,
including any attachments.
-----------------------------------------------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
