Hi Thien, OK, I see. Code Shellcheck don't allow use it. No more comment from me.
configure_tipc.in:25:6: note: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. [SC2181] Best Regards, ThuanTr -----Original Message----- From: Thien Minh Huynh <[email protected]> Sent: Friday, November 8, 2019 9:28 AM To: 'Tran Thuan' <[email protected]>; [email protected] Cc: [email protected] Subject: RE: [PATCH 1/1] nid: Change the path of TIPC_MODULE [#3110] Hi Thuan, When i run with "if [ $? -ne 0 ]; then" , the test_shellcheck is failed. So I use ret_val. Best Regards, ThienHuynh -----Original Message----- From: Tran Thuan <[email protected]> Sent: Friday, November 8, 2019 9:11 AM To: 'thien.m.huynh' <[email protected]>; [email protected] Cc: [email protected] Subject: RE: [PATCH 1/1] nid: Change the path of TIPC_MODULE [#3110] Hi Thien, ACK with minor comment inline. Best Regards, ThuanTr -----Original Message----- From: thien.m.huynh <[email protected]> Sent: Thursday, November 7, 2019 2:26 PM To: [email protected]; [email protected] Cc: [email protected]; thien.m.huynh <[email protected]> Subject: [PATCH 1/1] nid: Change the path of TIPC_MODULE [#3110] --- src/nid/configure_tipc.in | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/nid/configure_tipc.in b/src/nid/configure_tipc.in index 73dd1cb..218de65 100644 --- a/src/nid/configure_tipc.in +++ b/src/nid/configure_tipc.in @@ -21,7 +21,11 @@ . $pkgsysconfdir/nid.conf MANAGE_TIPC=${OPENSAF_MANAGE_TIPC:-"yes"} -TIPC_MODULE=/lib/modules/$(uname -r)/kernel/net/tipc.ko +TIPC_MODULE=$(modinfo tipc -n 2> /dev/null) ret_val=$? [Thuan] Not really need ret_val, can use $? In below IF, e.g: if [ $? -ne 0 ]; then +if [ $ret_val -ne 0 ] ; then + TIPC_MODULE=/lib/modules/$(uname -r)/kernel/net/tipc/tipc.ko fi CHASSIS_ID_FILE=$pkgsysconfdir/chassis_id SLOT_ID_FILE=$pkgsysconfdir/slot_id SUBSLOT_ID_FILE=$pkgsysconfdir/subslot_id -- 2.7.4 _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
