Summary: build: fix errors from gcc 9.x [#3134]
Review request for Ticket(s): 3134
Peer Reviewer(s): Tran
Pull request to:
Affected branch(es): develop
Development branch: ticket-3134
Base revision: 876fbce762044d49da8edbd6bfcb059ee59e748e
Personal repository: git://git.code.sf.net/u/trguitar/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system y
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 1c9c9c9aa23f95939597b0e29055c94c24e2815a
Author: Alex Jones <ajo...@rbbn.com>
Date: Mon, 3 Feb 2020 10:32:17 -0500
build: fix compile errors with gcc 9.x [#3134]
Rework fixes in NTF and SMF.
revision 560b3243c3bcd821ca67839de8a4ee2825422966
Author: Alex Jones <ajo...@rbbn.com>
Date: Mon, 3 Feb 2020 10:32:17 -0500
build: fix compile errors from gcc-9.x [#3134]
more issues
revision 2ccf53568405ea69bb5a1faf1a1eae9644702ab4
Author: Alex Jones <ajo...@rbbn.com>
Date: Mon, 3 Feb 2020 10:32:17 -0500
build: fix gcc-9.x compiler problems [#3134]
more fixes
revision 2bec1a88c54b6de9a8d49f98f3d2c1d97cc537a4
Author: Alex Jones <ajo...@rbbn.com>
Date: Mon, 3 Feb 2020 10:32:17 -0500
build: fix errors from gcc 9.x [#3134]
More compiler fixes
revision 17a27e953d743bb712f0c377091ee14c2e659b25
Author: Alex Jones <ajo...@rbbn.com>
Date: Mon, 3 Feb 2020 10:32:17 -0500
build: fix errors from gcc 9.x [#3134]
Mostly strncpy and strncat problems.
Complete diffstat:
------------------
src/base/daemon.c | 1 +
src/ckpt/ckptd/cpd_imm.c | 4 +-
src/ckpt/ckptnd/cpnd_res.c | 2 +-
src/clm/clmd/clms_imm.cc | 2 +-
src/dtm/dtmnd/dtm_intra_svc.cc | 2 +-
src/evt/evtd/eds_ll.c | 4 +-
src/imm/agent/imma_oi_api.cc | 3 +-
src/imm/agent/imma_om_api.cc | 14 ++----
src/imm/apitest/management/populate.c | 2 +-
.../apitest/management/test_saImmOmClassCreate_2.c | 16 +++----
src/imm/common/immpbe_dump.cc | 2 +-
src/imm/immd/immd_amf.c | 2 +-
src/imm/immloadd/imm_loader.cc | 10 ++--
src/imm/immloadd/imm_pbe_load.cc | 7 +--
src/imm/immnd/immnd_amf.c | 2 +-
src/imm/immnd/immnd_evt.c | 8 ++--
src/imm/tools/imm_cfg.c | 2 +-
src/imm/tools/imm_import.cc | 16 +++----
src/lck/lckd/gld_imm.c | 2 +-
src/log/agent/lga_agent.cc | 2 +-
src/log/apitest/logtest.c | 2 +-
src/log/apitest/tet_LogOiOps.c | 4 +-
src/log/logd/lgs_dest.cc | 6 +--
src/log/logd/lgs_util.cc | 10 ++--
src/mds/mds_c_api.c | 4 +-
src/msg/common/mqsv_common.c | 1 +
src/msg/msgnd/mqnd_evt.c | 1 +
src/msg/msgnd/mqnd_imm.c | 5 +-
src/msg/msgnd/mqnd_proc.c | 1 +
src/ntf/apitest/test_ntf_imcn.cc | 53 ++++++++++++++++------
src/plm/apitest/test_saPlmReadinessTrack.c | 24 +++++-----
src/plm/plmcd/plmc_read_config.c | 22 ++++-----
src/plm/plmcd/plmcd.c | 2 +-
src/plm/plmd/plms_imm.c | 5 +-
src/rde/rded/rde_rda.cc | 2 +-
src/smf/smfd/SmfUtils.cc | 14 ++----
src/smf/smfd/smfd_amf.cc | 2 +-
37 files changed, 137 insertions(+), 124 deletions(-)
Testing Commands:
-----------------
*** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES ***
Testing, Expected Results:
--------------------------
*** PASTE COMMAND OUTPUTS / TEST RESULTS ***
Conditions of Submission:
-------------------------
*** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC ***
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
-----------------------------------------------------------------------------------------------------------------------
Notice: This e-mail together with any attachments may contain information of
Ribbon Communications Inc. that
is confidential and/or proprietary for the sole use of the intended recipient.
Any review, disclosure, reliance or
distribution by others or forwarding without express permission is strictly
prohibited. If you are not the intended
recipient, please notify the sender immediately and then delete all copies,
including any attachments.
-----------------------------------------------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
