Hi Thang,

>From reproduce method, with solution after exit (instead of crash), user 
>continue input another operation then service exit again.
The point is why we cannot get admin owner or object implementer via 2nd imm 
modify callback in this scenario?
Is it an IMM limit that don't include admin owner or object implementer from 
2nd modify callback?

If limit, can we use another way to get admin owner or object implementer base 
on object name?
By this, we can avoid continuous exit if user keep going on operations by same 
CCB.

Best Regards,
ThuanTr

-----Original Message-----
From: Thang Duc Nguyen <thang.d.ngu...@dektech.com.au> 
Sent: Wednesday, April 15, 2020 3:43 PM
To: Minh Hon Chau <minh.c...@dektech.com.au>; Thuan Tran 
<thuan.t...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen 
<thang.d.ngu...@dektech.com.au>
Subject: [PATCH 1/1] ntf: restart ntfimcnd if it fails to get operation invoke 
name [#3178]

If ntfimcnd is restarted during ccb modify, it will initialize
ccbUtilCcbData that not contain operation invoke name.
This causes ntfimcnd crashed due to operation invoke name
not existed.

The fix is to restart ntfimcnd instead of raising the coredump.
---
 src/ntf/ntfimcnd/ntfimcn_imm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/ntf/ntfimcnd/ntfimcn_imm.c b/src/ntf/ntfimcnd/ntfimcn_imm.c
index 3c0a8c02a..3563a2264 100644
--- a/src/ntf/ntfimcnd/ntfimcn_imm.c
+++ b/src/ntf/ntfimcnd/ntfimcn_imm.c
@@ -376,9 +376,9 @@ get_operation_invoke_name_modify(SaImmOiCcbIdT ccbId,
                        goto done;
                }
        }
-       /* If we get here no name is found! */
+       /* ntfimcnd was restarted during ccb midify */
        LOG_ER("%s no name was found", __FUNCTION__);
-       osafassert(0);
+       imcn_exit(EXIT_FAILURE);
 
 done:
        TRACE_LEAVE();
-- 
2.17.1



_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to